Create compositor animations for effect animations in SPv2.

third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

Index: third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
index 6e6df1d3202e9192b3dd69c5ab6c9e87c3c4127c..40110221515dbb81ec03197e3e16bc20d6b238fd 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
@@ -1254,6 +1254,25 @@ TEST_F(AnimationCompositorAnimationsTest,
   EXPECT_TRUE(element->elementAnimations()->animations().isEmpty());
 }
 
+namespace {
+
+void updateDummyTransformNode(ObjectPaintProperties& properties,
+                              CompositingReasons reasons) {
+  properties.updateTransform(TransformPaintPropertyNode::root(),
+                             TransformationMatrix(), FloatPoint3D(), false, 0,
+                             reasons);
+}
+
+void updateDummyEffectNode(ObjectPaintProperties& properties,
+                           CompositingReasons reasons) {
+  properties.updateEffect(
+      EffectPaintPropertyNode::root(), TransformPaintPropertyNode::root(),
+      ClipPaintPropertyNode::root(), CompositorFilterOperations(), 1.0,
+      SkBlendMode::kSrcOver, reasons);
+}
+
+}  // namespace
+
 TEST_F(AnimationCompositorAnimationsTest,
        canStartAnimationOnCompositorTransformSPv2) {
   Persistent<Element> element = m_document->createElement("shared");
@@ -1266,15 +1285,11 @@ TEST_F(AnimationCompositorAnimationsTest,
 
   // Add a transform with a compositing reason, which should allow starting
   // animation.
-  properties.updateTransform(TransformPaintPropertyNode::root(),
-                             TransformationMatrix(), FloatPoint3D(), false, 0,
-                             CompositingReasonActiveAnimation);
+  updateDummyTransformNode(properties, CompositingReasonActiveAnimation);
   EXPECT_TRUE(CompositorAnimations::canStartAnimationOnCompositor(*element));
 
   // Setting to CompositingReasonNone should produce false.
-  properties.updateTransform(TransformPaintPropertyNode::root(),
-                             TransformationMatrix(), FloatPoint3D(), false, 0,
-                             CompositingReasonNone);
+  updateDummyTransformNode(properties, CompositingReasonNone);
   EXPECT_FALSE(CompositorAnimations::canStartAnimationOnCompositor(*element));
 
   // Clearing the transform node entirely should also produce false.
@@ -1285,4 +1300,31 @@ TEST_F(AnimationCompositorAnimationsTest,
   LayoutObjectProxy::dispose(layoutObject);
 }
 
+TEST_F(AnimationCompositorAnimationsTest,
+       canStartAnimationOnCompositorEffectSPv2) {
+  Persistent<Element> element = m_document->createElement("shared");
+  LayoutObjectProxy* layoutObject = LayoutObjectProxy::create(element.get());
+  element->setLayoutObject(layoutObject);
+
+  ScopedSlimmingPaintV2ForTest enableSPv2(true);
+  auto& properties =
+      layoutObject->getMutableForPainting().ensurePaintProperties();
+
+  // Add an effect with a compositing reason, which should allow starting
+  // animation.
+  updateDummyEffectNode(properties, CompositingReasonActiveAnimation);
+  EXPECT_TRUE(CompositorAnimations::canStartAnimationOnCompositor(*element));
+
+  // Setting to CompositingReasonNone should produce false.
+  updateDummyEffectNode(properties, CompositingReasonNone);
+  EXPECT_FALSE(CompositorAnimations::canStartAnimationOnCompositor(*element));
+
+  // Clearing the effect node entirely should also produce false.
+  properties.clearEffect();
+  EXPECT_FALSE(CompositorAnimations::canStartAnimationOnCompositor(*element));
+
+  element->setLayoutObject(nullptr);
+  LayoutObjectProxy::dispose(layoutObject);
+}
+
 }  // namespace blink