Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2595833003: Correct the behavior of createImageBitmap's "default" color space conversion (Closed)

Created:
4 years ago by zakerinasab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct the behavior of createImageBitmap's "default" color space conversion In ImageBitmap.cpp -> parseOptions, when color correct rendering is disabled, the destination color space for "default" color space conversion in createImageBitmap is set to sRGB. It must be set to display color profile. BUG=668546 Review-Url: https://codereview.chromium.org/2595833003 Cr-Commit-Position: refs/heads/master@{#441683} Committed: https://chromium.googlesource.com/chromium/src/+/73af4f477cdc6b962b8fd069353ea8df80af8491

Patch Set 1 #

Patch Set 2 : Replacing SRGB with display color profile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 3 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
zakerinasab1
New CL to correct the behavior of "default" color conversion in ImageBitmap. PTAL.
4 years ago (2016-12-22 16:04:31 UTC) #4
Justin Novosad
lgtm
3 years, 11 months ago (2017-01-05 15:44:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595833003/20001
3 years, 11 months ago (2017-01-05 15:45:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595833003/20001
3 years, 11 months ago (2017-01-05 16:14:12 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:20:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73af4f477cdc6b962b8fd069353e...

Powered by Google App Engine
This is Rietveld 408576698