Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

Issue 2595833003: Correct the behavior of createImageBitmap's "default" color space conversion (Closed)
Patch Set: Replacing SRGB with display color profile Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp b/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
index 6f54c5e19e83c894c6ace67cced25660411cf99b..ddf8122ac3934bb7a167a61b106762e736349dcb 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
@@ -297,10 +297,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionHTMLImageElement) {
NOTREACHED();
break;
case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:
- // TODO(zakerinasab): Replace sRGB with a call to
- // ImageDecoder::globalTargetColorSpace() when the crash problem on Mac
- // is fixed. crbug.com/668546.
- colorSpace = SkColorSpace::MakeNamed(SkColorSpace::kSRGB_Named);
+ colorSpace = ColorBehavior::globalTargetColorSpace();
colorFormat = colorFormat32;
break;
case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:
@@ -400,10 +397,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionImageBitmap) {
NOTREACHED();
break;
case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:
- // TODO(zakerinasab): Replace sRGB with a call to
- // ImageDecoder::globalTargetColorSpace() when the crash problem on Mac
- // is fixed. crbug.com/668546.
- colorSpace = SkColorSpace::MakeNamed(SkColorSpace::kSRGB_Named);
+ colorSpace = ColorBehavior::globalTargetColorSpace();
colorFormat = colorFormat32;
break;
case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:
@@ -494,10 +488,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionStaticBitmapImage) {
NOTREACHED();
break;
case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:
- // TODO(zakerinasab): Replace sRGB with a call to
- // ImageDecoder::globalTargetColorSpace() when the crash problem on Mac
- // is fixed. crbug.com/668546.
- colorSpace = SkColorSpace::MakeNamed(SkColorSpace::kSRGB_Named);
+ colorSpace = ColorBehavior::globalTargetColorSpace();
colorFormat = colorFormat32;
break;
case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:
« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698