Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2595833003: Correct the behavior of createImageBitmap's "default" color space conversion (Closed)
Patch Set: Replacing SRGB with display color profile Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index c22d88d5237e4b75d3e97b54153d0f07a513683d..f6ba656402cdc7ff7446b660d8daabca8a2ab30e 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -73,12 +73,8 @@ ParsedOptions parseOptions(const ImageBitmapOptions& options,
if (!RuntimeEnabledFeatures::experimentalCanvasFeaturesEnabled() ||
!RuntimeEnabledFeatures::colorCorrectRenderingEnabled()) {
DCHECK_EQ(options.colorSpaceConversion(), "default");
- // TODO(zakerinasab): Replace sRGB with a call to
- // ImageDecoder::globalTargetColorSpace() when the crash problem on Mac
- // is fixed. crbug.com/668546.
if (RuntimeEnabledFeatures::colorCorrectRenderingDefaultModeEnabled()) {
- parsedOptions.dstColorSpace =
- SkColorSpace::MakeNamed(SkColorSpace::kSRGB_Named);
+ parsedOptions.dstColorSpace = ColorBehavior::globalTargetColorSpace();
parsedOptions.dstColorType = SkColorType::kN32_SkColorType;
}
} else {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698