third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp - Issue 2595833003: Correct the behavior of createImageBitmap's "default" color space conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Issue 2595833003: Correct the behavior of createImageBitmap's "default" color space conversion (Closed)

Patch Set: Replacing SRGB with display color profile Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

index b820677ca70e88c5278df0aa46d3e8ed7febaa59..43a45fe3ce004c65aca6bd64ce2f0ba626beb2d3 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

@@ -1362,10 +1362,7 @@ TEST_F(CanvasRenderingContext2DTest, ImageBitmapColorSpaceConversion) {

NOTREACHED();

break;

case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:

- // TODO(zakerinasab): Replace sRGB with a call to

- // ImageDecoder::globalTargetColorSpace() when the crash problem on Mac

- // is fixed. crbug.com/668546.

- colorSpace = SkColorSpace::MakeNamed(SkColorSpace::kSRGB_Named);

+ colorSpace = ColorBehavior::globalTargetColorSpace();

colorFormat = colorFormat32;

break;

case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:

« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp ('k') | no next file » | no next file with comments »