Expand net::CookieStore::ChangeCause::EXPLICIT for debugging.

Expand net::CookieStore::ChangeCause::EXPLICIT for debugging.

This is to help track down where the ChangeCause::EXPLICIT that is seen
in GaiaCookieManagerService is coming from.

BUG=548423
Review-Url: https://codereview.chromium.org/2595703002
Cr-Commit-Position: refs/heads/master@{#442343}
Committed: https://chromium.googlesource.com/chromium/src/+/f6e9045bac175f482358c53e857cda6428b4700a

[nharper, 2016-12-20 22:36:20]

nharper@chromium.org changed reviewers:
+ mkwst@chromium.org, rdevlin.cronin@chromium.org, rogerta@chromium.org

[Devlin, 2016-12-20 23:20:26]

This looks rather weird to me, but if cookie owners are okay with it, then lgtm.

[nharper, 2016-12-20 23:40:23]

A bit more of an explanation for reviewers:

We're seeing in the GaiaFE logs requests from the GaiaCookieManagerService with
the url parameter source=ChromiumBrowserEXPLICIT. These requests appear to be
related to the bug attached to this CL, and we'd like to know more about where
these requests are coming from (or why Chrome is sending them). This CL should
help drill down on that cause.

[Mike West, 2016-12-22 07:31:09]

https://codereview.chromium.org/2595703002/diff/1/net/cookies/cookie_monster.cc
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2595703002/diff/1/net/cookies/cookie_monster....
net/cookies/cookie_monster.cc:285: {CookieStore::ChangeCause::EXPLICIT2, false},
Why not name them to match the cause in CookieMonster? That is, why `EXPLICIT2`
instead of `EXPLICIT_DUPLICATE_IN_BACKING_STORE`?

[nharper, 2016-12-23 01:42:55]

https://codereview.chromium.org/2595703002/diff/1/net/cookies/cookie_monster.cc
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2595703002/diff/1/net/cookies/cookie_monster....
net/cookies/cookie_monster.cc:285: {CookieStore::ChangeCause::EXPLICIT2, false},
On 2016/12/22 07:31:09, Mike West (OOO until the 9th) wrote:
> Why not name them to match the cause in CookieMonster? That is, why
`EXPLICIT2`
> instead of `EXPLICIT_DUPLICATE_IN_BACKING_STORE`?

Done.

[Mike West, 2017-01-09 09:03:13]

LGTM (happy holidays! Sorry for the delayed response.)

[Roger Tawa OOO till Jul 10th, 2017-01-09 19:06:56]

gaia_cookie_manager_service.cc lgtm

[nharper, 2017-01-09 19:33:59]

The CQ bit was checked by nharper@chromium.org

[nharper, 2017-01-09 19:33:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2595703002/#ps20001
(title: "better names for enum values")

[commit-bot: I haz the power, 2017-01-09 19:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:08:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483990439444530,
"parent_rev": "0e8beab6c0537dc462b96204491ef96e66628881", "commit_rev":
"f6e9045bac175f482358c53e857cda6428b4700a"}

[commit-bot: I haz the power, 2017-01-09 21:08:55]

Description was changed from

==========
Expand net::CookieStore::ChangeCause::EXPLICIT for debugging.

This is to help track down where the ChangeCause::EXPLICIT that is seen
in GaiaCookieManagerService is coming from.

BUG=548423
==========

to

==========
Expand net::CookieStore::ChangeCause::EXPLICIT for debugging.

This is to help track down where the ChangeCause::EXPLICIT that is seen
in GaiaCookieManagerService is coming from.

BUG=548423

Review-Url: https://codereview.chromium.org/2595703002
Cr-Commit-Position: refs/heads/master@{#442343}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6e9045bac175f482358c53e857c...
==========

[commit-bot: I haz the power, 2017-01-09 21:08:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f6e9045bac175f482358c53e857c...