Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: net/cookies/cookie_store.h

Issue 2595703002: Expand net::CookieStore::ChangeCause::EXPLICIT for debugging. (Closed)
Patch Set: better names for enum values Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Brought to you by number 42. 5 // Brought to you by number 42.
6 6
7 #ifndef NET_COOKIES_COOKIE_STORE_H_ 7 #ifndef NET_COOKIES_COOKIE_STORE_H_
8 #define NET_COOKIES_COOKIE_STORE_H_ 8 #define NET_COOKIES_COOKIE_STORE_H_
9 9
10 #include <memory> 10 #include <memory>
(...skipping 18 matching lines...) Expand all
29 // All async functions may either invoke the callback asynchronously, or they 29 // All async functions may either invoke the callback asynchronously, or they
30 // may be invoked immediately (prior to return of the asynchronous function). 30 // may be invoked immediately (prior to return of the asynchronous function).
31 // Destroying the CookieStore will cancel pending async callbacks. 31 // Destroying the CookieStore will cancel pending async callbacks.
32 class NET_EXPORT CookieStore { 32 class NET_EXPORT CookieStore {
33 public: 33 public:
34 // The publicly relevant reasons a cookie might be changed. 34 // The publicly relevant reasons a cookie might be changed.
35 enum class ChangeCause { 35 enum class ChangeCause {
36 // The cookie was inserted. 36 // The cookie was inserted.
37 INSERTED, 37 INSERTED,
38 // The cookie was changed directly by a consumer's action. 38 // The cookie was changed directly by a consumer's action.
39 EXPLICIT, 39 // The following enum values all have the same meaning, but are being used
40 // to track down where a bug came from.
41 // TODO(nharper): Remove all but one of these and rename to EXPLICIT once
42 // the one of interest has been found.
43 EXPLICIT_DELETE,
44 EXPLICIT_DUPLICATE_IN_BACKING_STORE,
45 EXPLICIT_DONT_RECORD,
46 EXPLICIT_LAST_ENTRY,
40 // The cookie was deleted, but no more details are known. 47 // The cookie was deleted, but no more details are known.
41 UNKNOWN_DELETION, 48 UNKNOWN_DELETION,
42 // The cookie was automatically removed due to an insert operation that 49 // The cookie was automatically removed due to an insert operation that
43 // overwrote it. 50 // overwrote it.
44 OVERWRITE, 51 OVERWRITE,
45 // The cookie was automatically removed as it expired. 52 // The cookie was automatically removed as it expired.
46 EXPIRED, 53 EXPIRED,
47 // The cookie was automatically evicted during garbage collection. 54 // The cookie was automatically evicted during garbage collection.
48 EVICTED, 55 EVICTED,
49 // The cookie was overwritten with an already-expired expiration date. 56 // The cookie was overwritten with an already-expired expiration date.
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 int GetChannelIDServiceID(); 243 int GetChannelIDServiceID();
237 244
238 protected: 245 protected:
239 CookieStore(); 246 CookieStore();
240 int channel_id_service_id_; 247 int channel_id_service_id_;
241 }; 248 };
242 249
243 } // namespace net 250 } // namespace net
244 251
245 #endif // NET_COOKIES_COOKIE_STORE_H_ 252 #endif // NET_COOKIES_COOKIE_STORE_H_
OLDNEW
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698