Fix CSS clips cannot be correctly handled by composited scroller

Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/141c10c87f8f4bba2d4036e1613e1d9455256c45
Cr-Commit-Position: refs/heads/master@{#440925}

[yigu, 2016-12-20 15:29:53]

Description was changed from

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
==========

to

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[yigu, 2016-12-20 15:35:45]

yigu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[yigu, 2016-12-20 15:35:45]

yigu@chromium.org changed required reviewers:
+ chrishtr@chromium.org

[yigu, 2016-12-20 15:35:46]

Hi Chris,
Currently I'm fixing the bug by not compositing a layer that has css clip. Not
sure this is the best way to do so. PTAL.
Thanks!
Yi

[chrishtr, 2016-12-28 16:17:45]

This CL also needs a test.

https://codereview.chromium.org/2595593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right):

https://codereview.chromium.org/2595593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:1758:
!layer->layoutObject()->style()->hasAutoClip());
Instead, write this:

layer->layoutObject()->hasClip()

[yigu, 2016-12-28 17:18:28]

Description was changed from

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[yigu, 2016-12-28 18:42:06]

Hi Chris, 
Thanks for the feedback! A unit test has been added. PTAL.
Yi

https://codereview.chromium.org/2595593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp (right):

https://codereview.chromium.org/2595593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp:1758:
!layer->layoutObject()->style()->hasAutoClip());
On 2016/12/28 16:17:44, chrishtr wrote:
> Instead, write this:
> 
> layer->layoutObject()->hasClip()

Done.

[chrishtr, 2016-12-29 01:27:28]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-29 01:27:28]

lgtm

[commit-bot: I haz the power, 2016-12-29 01:27:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 02:14:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482974848601960,
"parent_rev": "1980d836eb85cd06e0ab7c1b8b7b7fba84285cb6", "commit_rev":
"7b8226bd1185796cbcf52473603033f93247bd93"}

[commit-bot: I haz the power, 2016-12-29 02:15:24]

Description was changed from

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2595593002
==========

[commit-bot: I haz the power, 2016-12-29 02:15:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:51:25]

Description was changed from

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2595593002
==========

to

==========
Fix CSS clips cannot be correctly handled by composited scroller

BUG=645957
TEST=PaintLayerScrollableAreaTest.OnlyAutoClippedScrollingContentsLayerPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/141c10c87f8f4bba2d4036e1613e1d9455256c45
Cr-Commit-Position: refs/heads/master@{#440925}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:26]

Patchset 2 (id:??) landed as
https://crrev.com/141c10c87f8f4bba2d4036e1613e1d9455256c45
Cr-Commit-Position: refs/heads/master@{#440925}