Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2595593002: Fix CSS clips cannot be correctly handled by composited scroller (Closed)
Patch Set: Add unit test && nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1744 matching lines...) Expand 10 before | Expand all | Expand 10 after
1755 } 1755 }
1756 return false; 1756 return false;
1757 } 1757 }
1758 1758
1759 // TODO(schenney) Tests fail if we do not also exclude 1759 // TODO(schenney) Tests fail if we do not also exclude
1760 // layer->layoutObject()->style()->hasBorderDecoration() (missing background 1760 // layer->layoutObject()->style()->hasBorderDecoration() (missing background
1761 // behind dashed borders). Resolve this case, or not, and update this check 1761 // behind dashed borders). Resolve this case, or not, and update this check
1762 // with the results. 1762 // with the results.
1763 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() || 1763 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() ||
1764 layer->hasAncestorWithClipPath() || 1764 layer->hasAncestorWithClipPath() ||
1765 layer->layoutObject()->style()->hasBorderRadius()); 1765 layer->layoutObject()->style()->hasBorderRadius() ||
1766 layer->layoutObject()->hasClip());
1766 } 1767 }
1767 1768
1768 void PaintLayerScrollableArea::addStyleRelatedMainThreadScrollingReasons( 1769 void PaintLayerScrollableArea::addStyleRelatedMainThreadScrollingReasons(
1769 const uint32_t reason) { 1770 const uint32_t reason) {
1770 LocalFrame* frame = box().frame(); 1771 LocalFrame* frame = box().frame();
1771 if (!frame) 1772 if (!frame)
1772 return; 1773 return;
1773 FrameView* frameView = frame->view(); 1774 FrameView* frameView = frame->view();
1774 if (!frameView) 1775 if (!frameView)
1775 return; 1776 return;
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 2072
2072 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2073 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2073 clampScrollableAreas() { 2074 clampScrollableAreas() {
2074 for (auto& scrollableArea : *s_needsClamp) 2075 for (auto& scrollableArea : *s_needsClamp)
2075 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2076 scrollableArea->clampScrollOffsetAfterOverflowChange();
2076 delete s_needsClamp; 2077 delete s_needsClamp;
2077 s_needsClamp = nullptr; 2078 s_needsClamp = nullptr;
2078 } 2079 }
2079 2080
2080 } // namespace blink 2081 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698