third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2595593002: Fix CSS clips cannot be correctly handled by composited scroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2595593002: Fix CSS clips cannot be correctly handled by composited scroller (Closed)

Patch Set: Add unit test && nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 02acdf83b4ad1f058f8df66434a0cd8dd5dce209..7a7d3894ed88097c3eff07c36ea5c819f6b11e88 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1762,7 +1762,8 @@ bool PaintLayerScrollableArea::computeNeedsCompositedScrolling(

// with the results.

return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() ||

layer->hasAncestorWithClipPath() ||

- layer->layoutObject()->style()->hasBorderRadius());

+ layer->layoutObject()->style()->hasBorderRadius() ||

+ layer->layoutObject()->hasClip());

}

void PaintLayerScrollableArea::addStyleRelatedMainThreadScrollingReasons(

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »