Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2595593002: Fix CSS clips cannot be correctly handled by composited scroller (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1747 !layer->compositor()->preferCompositingToLCDTextEnabled() && 1747 !layer->compositor()->preferCompositingToLCDTextEnabled() &&
1748 !backgroundSupportsLCDText) 1748 !backgroundSupportsLCDText)
1749 return false; 1749 return false;
1750 1750
1751 // TODO(schenney) Tests fail if we do not also exclude 1751 // TODO(schenney) Tests fail if we do not also exclude
1752 // layer->layoutObject()->style()->hasBorderDecoration() (missing background 1752 // layer->layoutObject()->style()->hasBorderDecoration() (missing background
1753 // behind dashed borders). Resolve this case, or not, and update this check 1753 // behind dashed borders). Resolve this case, or not, and update this check
1754 // with the results. 1754 // with the results.
1755 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() || 1755 return !(layer->size().isEmpty() || layer->hasDescendantWithClipPath() ||
1756 layer->hasAncestorWithClipPath() || 1756 layer->hasAncestorWithClipPath() ||
1757 layer->layoutObject()->style()->hasBorderRadius()); 1757 layer->layoutObject()->style()->hasBorderRadius() ||
1758 !layer->layoutObject()->style()->hasAutoClip());
chrishtr 2016/12/28 16:17:44 Instead, write this: layer->layoutObject()->hasCl
yigu 2016/12/28 18:42:06 Done.
1758 } 1759 }
1759 1760
1760 void PaintLayerScrollableArea::updateNeedsCompositedScrolling( 1761 void PaintLayerScrollableArea::updateNeedsCompositedScrolling(
1761 LCDTextMode mode) { 1762 LCDTextMode mode) {
1762 const bool needsCompositedScrolling = 1763 const bool needsCompositedScrolling =
1763 layerNeedsCompositedScrolling(mode, layer()); 1764 layerNeedsCompositedScrolling(mode, layer());
1764 if (static_cast<bool>(m_needsCompositedScrolling) != 1765 if (static_cast<bool>(m_needsCompositedScrolling) !=
1765 needsCompositedScrolling) { 1766 needsCompositedScrolling) {
1766 m_needsCompositedScrolling = needsCompositedScrolling; 1767 m_needsCompositedScrolling = needsCompositedScrolling;
1767 layer()->didUpdateNeedsCompositedScrolling(); 1768 layer()->didUpdateNeedsCompositedScrolling();
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
2026 2027
2027 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2028 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2028 clampScrollableAreas() { 2029 clampScrollableAreas() {
2029 for (auto& scrollableArea : *s_needsClamp) 2030 for (auto& scrollableArea : *s_needsClamp)
2030 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2031 scrollableArea->clampScrollOffsetAfterOverflowChange();
2031 delete s_needsClamp; 2032 delete s_needsClamp;
2032 s_needsClamp = nullptr; 2033 s_needsClamp = nullptr;
2033 } 2034 }
2034 2035
2035 } // namespace blink 2036 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698