Mojo JS bindings: fix enum array validation.

Mojo JS bindings: fix enum array validation.

BUG=579646, 581390
Committed: https://crrev.com/2393542f5fe8d750846c1a3d3f6e6130df3d0153
Cr-Commit-Position: refs/heads/master@{#440290}

[yzshen1, 2016-12-21 22:44:37]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-21 22:55:03]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-21 23:02:46]

yzshen@chromium.org changed reviewers:
+ jcivelli@chromium.org

[yzshen1, 2016-12-21 23:02:47]

Hi, Jay.

Would you please take a look? Thanks!

[Jay Civelli, 2016-12-21 23:14:52]

I am not very familiar with the binding code yet, but this LGTM.

https://codereview.chromium.org/2595563004/diff/20001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2595563004/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_js_generator.py:238: return
enum_type
Nit: is the local var needed?

[yzshen1, 2016-12-21 23:17:36]

Thanks Jay!

https://codereview.chromium.org/2595563004/diff/20001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2595563004/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_js_generator.py:238: return
enum_type
On 2016/12/21 23:14:52, Jay Civelli wrote:
> Nit: is the local var needed?

Done.

[yzshen1, 2016-12-21 23:17:40]

Thanks Jay!

[yzshen1, 2016-12-21 23:17:47]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-12-21 23:17:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcivelli@chromium.org
Link to the patchset: https://codereview.chromium.org/2595563004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-12-21 23:18:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:03:26]

Internal error: failed to checkout. Please try again.

[yzshen1, 2016-12-22 01:04:13]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:04:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:09:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482368653823420,
"parent_rev": "ef111b0dad3b3a1b5265577705c5d3a459092493", "commit_rev":
"22ab59a62abd5f993f24a8159e1d9cc3ae2aca0b"}

[commit-bot: I haz the power, 2016-12-22 01:14:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482368653823420,
"parent_rev": "6d55da5c5ee9cb7bd07874494686289aa7cf8d32", "commit_rev":
"d48fd4c075869b0ed6938f1f36d5eb40998c2828"}

[commit-bot: I haz the power, 2016-12-22 01:15:09]

Description was changed from

==========
Mojo JS bindings: fix enum array validation.

BUG=579646,581390
==========

to

==========
Mojo JS bindings: fix enum array validation.

BUG=579646,581390

Review-Url: https://codereview.chromium.org/2595563004
==========

[commit-bot: I haz the power, 2016-12-22 01:15:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 01:17:59]

Description was changed from

==========
Mojo JS bindings: fix enum array validation.

BUG=579646,581390

Review-Url: https://codereview.chromium.org/2595563004
==========

to

==========
Mojo JS bindings: fix enum array validation.

BUG=579646,581390

Committed: https://crrev.com/2393542f5fe8d750846c1a3d3f6e6130df3d0153
Cr-Commit-Position: refs/heads/master@{#440290}
==========

[commit-bot: I haz the power, 2016-12-22 01:18:00]

Patchset 3 (id:??) landed as
https://crrev.com/2393542f5fe8d750846c1a3d3f6e6130df3d0153
Cr-Commit-Position: refs/heads/master@{#440290}