Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2594213002: Mojo JS bindings: change usb layout tests to use the new "bindings" module. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: change usb layout tests to use the new "bindings" module. BUG=579646 Committed: https://crrev.com/fdfe332b3a5063b61a3bfc940bbeb08f2eb63cd6 Cr-Commit-Position: refs/heads/master@{#440324}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 2 7 chunks +20 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usbDevice-iframe.html View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (14 generated)
yzshen1
Hi, Reilly. Would you please take a look? Thanks!
4 years ago (2016-12-22 00:11:14 UTC) #4
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/2594213002/diff/20001/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js File third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js (right): https://codereview.chromium.org/2594213002/diff/20001/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js#newcode383 third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js:383: deviceData.stubs.push(binding); We should rename |stubs| to |bindings|.
4 years ago (2016-12-22 00:35:07 UTC) #5
yzshen1
https://codereview.chromium.org/2594213002/diff/20001/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js File third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js (right): https://codereview.chromium.org/2594213002/diff/20001/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js#newcode383 third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js:383: deviceData.stubs.push(binding); On 2016/12/22 00:35:07, Reilly Grant wrote: > We ...
4 years ago (2016-12-22 00:44:46 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2595563004 Patch 40001). Please resolve the dependency and ...
4 years ago (2016-12-22 00:44:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594213002/40001
4 years ago (2016-12-22 03:30:58 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-22 03:34:45 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-22 03:37:13 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fdfe332b3a5063b61a3bfc940bbeb08f2eb63cd6
Cr-Commit-Position: refs/heads/master@{#440324}

Powered by Google App Engine
This is Rietveld 408576698