mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data - Issue 2595563004: Mojo JS bindings: fix enum array validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data

Issue 2595563004: Mojo JS bindings: fix enum array validation. (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.expected » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data

diff --git a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_uknown_non_extensible_enum_array_value.data b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data

similarity index 66%

copy from mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_uknown_non_extensible_enum_array_value.data

copy to mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data

index 1cd348490d712a9af42d1125e111771a79f13e4d..21af8a3df1da261b6b17bb6a133730a18bf0c328 100644

--- a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_uknown_non_extensible_enum_array_value.data

+++ b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd15_good_empy_enum_array.data

@@ -14,8 +14,9 @@

[anchr]enum_array_0

[dist4]enum_array_0_member // num_bytes

-[u4]2 // num_elements

-[u4]0x5678 // Unknown value is not allowed for non-extensible

- // enum.

-[u4]1

+[u4]0 // num_elements

[anchr]enum_array_0_member

+[u8]0x5678 // This is not part of the array above (which is

+ // empty), so enum validation shouldn't be done on

+ // it.