mojo/public/tools/bindings/generators/mojom_js_generator.py - Issue 2595563004: Mojo JS bindings: fix enum array validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 2595563004: Mojo JS bindings: fix enum array validation. (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py

index 0d774a597f138c3ecb66771c08d8d70fedc69238..0eedb314453c1d9d86bc376855ce3fbe02a81e43 100644

--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py

@@ -234,9 +234,7 @@ def JavaScriptValidateArrayParams(field):

def JavaScriptValidateEnumParams(field):

- nullable = JavaScriptNullableParam(field)

- enum_type = JavaScriptType(field.kind)

- return "%s, %s" % (enum_type, nullable)

+ return JavaScriptType(field.kind)

def JavaScriptValidateStructParams(field):

nullable = JavaScriptNullableParam(field)