Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix long comments. #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -551 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 8 chunks +16 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 10 chunks +8 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 21 chunks +58 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 2 4 chunks +3 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 12 chunks +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 4 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 23 chunks +51 lines, -53 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 5 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 14 chunks +24 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 6 chunks +15 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 8 chunks +16 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 22 chunks +66 lines, -61 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 5 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 10 chunks +14 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 8 chunks +17 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 7 chunks +13 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 11 chunks +10 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 7 chunks +9 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-20 10:34:43 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2595493002/diff/20001/pkg/compiler/lib/src/core_types.dart File pkg/compiler/lib/src/core_types.dart (right): https://codereview.chromium.org/2595493002/diff/20001/pkg/compiler/lib/src/core_types.dart#newcode189 pkg/compiler/lib/src/core_types.dart:189: ClassElement get futureClass; let's move it up (keep ...
4 years ago (2016-12-20 19:22:30 UTC) #3
Johnni Winther
https://codereview.chromium.org/2595493002/diff/20001/pkg/compiler/lib/src/core_types.dart File pkg/compiler/lib/src/core_types.dart (right): https://codereview.chromium.org/2595493002/diff/20001/pkg/compiler/lib/src/core_types.dart#newcode189 pkg/compiler/lib/src/core_types.dart:189: ClassElement get futureClass; On 2016/12/20 19:22:30, Siggi Cherem (dart-lang) ...
4 years ago (2016-12-21 09:01:04 UTC) #4
Johnni Winther
4 years ago (2016-12-21 09:10:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6281614c45d6c0cc56a60636f64268943549cc9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698