Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)
Patch Set: Updated cf. comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_helpers.impact; 5 library dart2js.js_helpers.impact;
6 6
7 import '../common/names.dart'; 7 import '../common/names.dart';
8 import '../compiler.dart' show Compiler; 8 import '../compiler.dart' show Compiler;
9 import '../core_types.dart' show CommonElements; 9 import '../core_types.dart' show CommonElements;
10 import '../dart_types.dart' show InterfaceType; 10 import '../dart_types.dart' show InterfaceType;
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 new BackendImpact(globalClasses: [helpers.closureClass]); 572 new BackendImpact(globalClasses: [helpers.closureClass]);
573 } 573 }
574 574
575 BackendImpact _mapClass; 575 BackendImpact _mapClass;
576 576
577 BackendImpact get mapClass { 577 BackendImpact get mapClass {
578 return _mapClass ??= new BackendImpact( 578 return _mapClass ??= new BackendImpact(
579 // The backend will use a literal list to initialize the entries 579 // The backend will use a literal list to initialize the entries
580 // of the map. 580 // of the map.
581 globalClasses: [ 581 globalClasses: [
582 helpers.coreClasses.listClass, 582 helpers.commonElements.listClass,
583 helpers.mapLiteralClass 583 helpers.mapLiteralClass
584 ]); 584 ]);
585 } 585 }
586 586
587 BackendImpact _boundClosureClass; 587 BackendImpact _boundClosureClass;
588 588
589 BackendImpact get boundClosureClass { 589 BackendImpact get boundClosureClass {
590 return _boundClosureClass ??= 590 return _boundClosureClass ??=
591 new BackendImpact(globalClasses: [helpers.boundClosureClass]); 591 new BackendImpact(globalClasses: [helpers.boundClosureClass]);
592 } 592 }
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 666
667 BackendImpact get assertUnreachable { 667 BackendImpact get assertUnreachable {
668 return _assertUnreachable ??= 668 return _assertUnreachable ??=
669 new BackendImpact(globalUses: [helpers.assertUnreachableMethod]); 669 new BackendImpact(globalUses: [helpers.assertUnreachableMethod]);
670 } 670 }
671 671
672 BackendImpact _runtimeTypeSupport; 672 BackendImpact _runtimeTypeSupport;
673 673
674 BackendImpact get runtimeTypeSupport { 674 BackendImpact get runtimeTypeSupport {
675 return _runtimeTypeSupport ??= new BackendImpact( 675 return _runtimeTypeSupport ??= new BackendImpact(
676 globalClasses: [helpers.coreClasses.listClass], 676 globalClasses: [helpers.commonElements.listClass],
677 globalUses: [helpers.setRuntimeTypeInfo, helpers.getRuntimeTypeInfo], 677 globalUses: [helpers.setRuntimeTypeInfo, helpers.getRuntimeTypeInfo],
678 otherImpacts: [getRuntimeTypeArgument, computeSignature]); 678 otherImpacts: [getRuntimeTypeArgument, computeSignature]);
679 } 679 }
680 680
681 BackendImpact _deferredLoading; 681 BackendImpact _deferredLoading;
682 682
683 BackendImpact get deferredLoading { 683 BackendImpact get deferredLoading {
684 return _deferredLoading ??= 684 return _deferredLoading ??=
685 new BackendImpact(globalUses: [helpers.checkDeferredIsLoaded], 685 new BackendImpact(globalUses: [helpers.checkDeferredIsLoaded],
686 // Also register the types of the arguments passed to this method. 686 // Also register the types of the arguments passed to this method.
687 globalClasses: [helpers.coreClasses.stringClass]); 687 globalClasses: [helpers.commonElements.stringClass]);
688 } 688 }
689 689
690 BackendImpact _noSuchMethodSupport; 690 BackendImpact _noSuchMethodSupport;
691 691
692 BackendImpact get noSuchMethodSupport { 692 BackendImpact get noSuchMethodSupport {
693 return _noSuchMethodSupport ??= new BackendImpact( 693 return _noSuchMethodSupport ??= new BackendImpact(
694 staticUses: [helpers.createInvocationMirror], 694 staticUses: [helpers.createInvocationMirror],
695 dynamicUses: [Selectors.noSuchMethod_]); 695 dynamicUses: [Selectors.noSuchMethod_]);
696 } 696 }
697 697
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 730
731 BackendImpact _staticClosure; 731 BackendImpact _staticClosure;
732 732
733 /// Backend impact for performing closurization of a top-level or static 733 /// Backend impact for performing closurization of a top-level or static
734 /// function. 734 /// function.
735 BackendImpact get staticClosure { 735 BackendImpact get staticClosure {
736 return _staticClosure ??= 736 return _staticClosure ??=
737 new BackendImpact(globalClasses: [helpers.closureClass]); 737 new BackendImpact(globalClasses: [helpers.closureClass]);
738 } 738 }
739 } 739 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend_helpers.dart ('k') | pkg/compiler/lib/src/js_backend/constant_system_javascript.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698