Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)
Patch Set: Updated cf. comment Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter.program_builder; 5 part of dart2js.js_emitter.program_builder;
6 6
7 /** 7 /**
8 * Generates the code for all used classes in the program. Static fields (even 8 * Generates the code for all used classes in the program. Static fields (even
9 * in classes) are ignored, since they can be treated as non-class elements. 9 * in classes) are ignored, since they can be treated as non-class elements.
10 * 10 *
(...skipping 27 matching lines...) Expand all
38 bool outputContainsConstantList = false; 38 bool outputContainsConstantList = false;
39 39
40 final List<ClassElement> nativeClassesAndSubclasses = <ClassElement>[]; 40 final List<ClassElement> nativeClassesAndSubclasses = <ClassElement>[];
41 41
42 List<TypedefElement> typedefsNeededForReflection; 42 List<TypedefElement> typedefsNeededForReflection;
43 43
44 JavaScriptBackend get backend => compiler.backend; 44 JavaScriptBackend get backend => compiler.backend;
45 45
46 BackendHelpers get helpers => backend.helpers; 46 BackendHelpers get helpers => backend.helpers;
47 47
48 CoreClasses get coreClasses => compiler.coreClasses; 48 CommonElements get commonElements => compiler.commonElements;
49 49
50 Collector(this.compiler, this.namer, this.closedWorld, this.rtiNeededClasses, 50 Collector(this.compiler, this.namer, this.closedWorld, this.rtiNeededClasses,
51 this.emitter); 51 this.emitter);
52 52
53 Set<ClassElement> computeInterceptorsReferencedFromConstants() { 53 Set<ClassElement> computeInterceptorsReferencedFromConstants() {
54 Set<ClassElement> classes = new Set<ClassElement>(); 54 Set<ClassElement> classes = new Set<ClassElement>();
55 JavaScriptConstantCompiler handler = backend.constants; 55 JavaScriptConstantCompiler handler = backend.constants;
56 List<ConstantValue> constants = handler.getConstantsForEmission(); 56 List<ConstantValue> constants = handler.getConstantsForEmission();
57 for (ConstantValue constant in constants) { 57 for (ConstantValue constant in constants) {
58 if (constant is InterceptorConstantValue) { 58 if (constant is InterceptorConstantValue) {
59 InterceptorConstantValue interceptorConstant = constant; 59 InterceptorConstantValue interceptorConstant = constant;
60 classes.add(interceptorConstant.dispatchedType.element); 60 classes.add(interceptorConstant.dispatchedType.element);
61 } 61 }
62 } 62 }
63 return classes; 63 return classes;
64 } 64 }
65 65
66 /** 66 /**
67 * Return a function that returns true if its argument is a class 67 * Return a function that returns true if its argument is a class
68 * that needs to be emitted. 68 * that needs to be emitted.
69 */ 69 */
70 Function computeClassFilter() { 70 Function computeClassFilter() {
71 if (backend.isTreeShakingDisabled) return (ClassElement cls) => true; 71 if (backend.isTreeShakingDisabled) return (ClassElement cls) => true;
72 72
73 Set<ClassElement> unneededClasses = new Set<ClassElement>(); 73 Set<ClassElement> unneededClasses = new Set<ClassElement>();
74 // The [Bool] class is not marked as abstract, but has a factory 74 // The [Bool] class is not marked as abstract, but has a factory
75 // constructor that always throws. We never need to emit it. 75 // constructor that always throws. We never need to emit it.
76 unneededClasses.add(coreClasses.boolClass); 76 unneededClasses.add(commonElements.boolClass);
77 77
78 // Go over specialized interceptors and then constants to know which 78 // Go over specialized interceptors and then constants to know which
79 // interceptors are needed. 79 // interceptors are needed.
80 Set<ClassElement> needed = new Set<ClassElement>(); 80 Set<ClassElement> needed = new Set<ClassElement>();
81 backend.specializedGetInterceptors 81 backend.specializedGetInterceptors
82 .forEach((_, Iterable<ClassElement> elements) { 82 .forEach((_, Iterable<ClassElement> elements) {
83 needed.addAll(elements); 83 needed.addAll(elements);
84 }); 84 });
85 85
86 // Add interceptors referenced by constants. 86 // Add interceptors referenced by constants.
87 needed.addAll(computeInterceptorsReferencedFromConstants()); 87 needed.addAll(computeInterceptorsReferencedFromConstants());
88 88
89 // Add unneeded interceptors to the [unneededClasses] set. 89 // Add unneeded interceptors to the [unneededClasses] set.
90 for (ClassElement interceptor in backend.interceptedClasses) { 90 for (ClassElement interceptor in backend.interceptedClasses) {
91 if (!needed.contains(interceptor) && 91 if (!needed.contains(interceptor) &&
92 interceptor != coreClasses.objectClass) { 92 interceptor != commonElements.objectClass) {
93 unneededClasses.add(interceptor); 93 unneededClasses.add(interceptor);
94 } 94 }
95 } 95 }
96 96
97 // These classes are just helpers for the backend's type system. 97 // These classes are just helpers for the backend's type system.
98 unneededClasses.add(helpers.jsMutableArrayClass); 98 unneededClasses.add(helpers.jsMutableArrayClass);
99 unneededClasses.add(helpers.jsFixedArrayClass); 99 unneededClasses.add(helpers.jsFixedArrayClass);
100 unneededClasses.add(helpers.jsExtendableArrayClass); 100 unneededClasses.add(helpers.jsExtendableArrayClass);
101 unneededClasses.add(helpers.jsUInt32Class); 101 unneededClasses.add(helpers.jsUInt32Class);
102 unneededClasses.add(helpers.jsUInt31Class); 102 unneededClasses.add(helpers.jsUInt31Class);
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 // codegen'd. The rtiNeededClasses may contain additional classes, but 213 // codegen'd. The rtiNeededClasses may contain additional classes, but
214 // these are thought to not have been instantiated, so we neeed to be able 214 // these are thought to not have been instantiated, so we neeed to be able
215 // to identify them later and make sure we only emit "empty shells" without 215 // to identify them later and make sure we only emit "empty shells" without
216 // fields, etc. 216 // fields, etc.
217 classesOnlyNeededForRti = rtiNeededClasses.difference(neededClasses); 217 classesOnlyNeededForRti = rtiNeededClasses.difference(neededClasses);
218 218
219 neededClasses.addAll(classesOnlyNeededForRti); 219 neededClasses.addAll(classesOnlyNeededForRti);
220 220
221 // TODO(18175, floitsch): remove once issue 18175 is fixed. 221 // TODO(18175, floitsch): remove once issue 18175 is fixed.
222 if (neededClasses.contains(helpers.jsIntClass)) { 222 if (neededClasses.contains(helpers.jsIntClass)) {
223 neededClasses.add(coreClasses.intClass); 223 neededClasses.add(commonElements.intClass);
224 } 224 }
225 if (neededClasses.contains(helpers.jsDoubleClass)) { 225 if (neededClasses.contains(helpers.jsDoubleClass)) {
226 neededClasses.add(coreClasses.doubleClass); 226 neededClasses.add(commonElements.doubleClass);
227 } 227 }
228 if (neededClasses.contains(helpers.jsNumberClass)) { 228 if (neededClasses.contains(helpers.jsNumberClass)) {
229 neededClasses.add(coreClasses.numClass); 229 neededClasses.add(commonElements.numClass);
230 } 230 }
231 if (neededClasses.contains(helpers.jsStringClass)) { 231 if (neededClasses.contains(helpers.jsStringClass)) {
232 neededClasses.add(coreClasses.stringClass); 232 neededClasses.add(commonElements.stringClass);
233 } 233 }
234 if (neededClasses.contains(helpers.jsBoolClass)) { 234 if (neededClasses.contains(helpers.jsBoolClass)) {
235 neededClasses.add(coreClasses.boolClass); 235 neededClasses.add(commonElements.boolClass);
236 } 236 }
237 if (neededClasses.contains(helpers.jsArrayClass)) { 237 if (neededClasses.contains(helpers.jsArrayClass)) {
238 neededClasses.add(coreClasses.listClass); 238 neededClasses.add(commonElements.listClass);
239 } 239 }
240 240
241 // 4. Finally, sort the classes. 241 // 4. Finally, sort the classes.
242 List<ClassElement> sortedClasses = Elements.sortedByPosition(neededClasses); 242 List<ClassElement> sortedClasses = Elements.sortedByPosition(neededClasses);
243 243
244 for (ClassElement element in sortedClasses) { 244 for (ClassElement element in sortedClasses) {
245 if (backend.isNativeOrExtendsNative(element) && 245 if (backend.isNativeOrExtendsNative(element) &&
246 !classesOnlyNeededForRti.contains(element)) { 246 !classesOnlyNeededForRti.contains(element)) {
247 // For now, native classes and related classes cannot be deferred. 247 // For now, native classes and related classes cannot be deferred.
248 nativeClassesAndSubclasses.add(element); 248 nativeClassesAndSubclasses.add(element);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 } 317 }
318 318
319 void collect() { 319 void collect() {
320 computeNeededDeclarations(); 320 computeNeededDeclarations();
321 computeNeededConstants(); 321 computeNeededConstants();
322 computeNeededStatics(); 322 computeNeededStatics();
323 computeNeededStaticNonFinalFields(); 323 computeNeededStaticNonFinalFields();
324 computeNeededLibraries(); 324 computeNeededLibraries();
325 } 325 }
326 } 326 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698