Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)
Patch Set: Updated cf. comment Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_emitter.startup_emitter; 5 library dart2js.js_emitter.startup_emitter;
6 6
7 import 'package:js_runtime/shared/embedded_names.dart' 7 import 'package:js_runtime/shared/embedded_names.dart'
8 show JsBuiltin, METADATA, STATIC_FUNCTION_NAME_TO_CLOSURE, TYPES; 8 show JsBuiltin, METADATA, STATIC_FUNCTION_NAME_TO_CLOSURE, TYPES;
9 9
10 import '../../common.dart'; 10 import '../../common.dart';
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 return _globalPropertyAccess(element); 139 return _globalPropertyAccess(element);
140 } 140 }
141 141
142 @override 142 @override
143 js.Template templateForBuiltin(JsBuiltin builtin) { 143 js.Template templateForBuiltin(JsBuiltin builtin) {
144 String typeNameProperty = ModelEmitter.typeNameProperty; 144 String typeNameProperty = ModelEmitter.typeNameProperty;
145 145
146 switch (builtin) { 146 switch (builtin) {
147 case JsBuiltin.dartObjectConstructor: 147 case JsBuiltin.dartObjectConstructor:
148 return js.js.expressionTemplateYielding( 148 return js.js.expressionTemplateYielding(
149 typeAccess(_compiler.coreClasses.objectClass)); 149 typeAccess(_compiler.commonElements.objectClass));
150 150
151 case JsBuiltin.isCheckPropertyToJsConstructorName: 151 case JsBuiltin.isCheckPropertyToJsConstructorName:
152 int isPrefixLength = namer.operatorIsPrefix.length; 152 int isPrefixLength = namer.operatorIsPrefix.length;
153 return js.js.expressionTemplateFor('#.substring($isPrefixLength)'); 153 return js.js.expressionTemplateFor('#.substring($isPrefixLength)');
154 154
155 case JsBuiltin.isFunctionType: 155 case JsBuiltin.isFunctionType:
156 return _backend.rtiEncoder.templateForIsFunctionType; 156 return _backend.rtiEncoder.templateForIsFunctionType;
157 157
158 case JsBuiltin.rawRtiToJsConstructorName: 158 case JsBuiltin.rawRtiToJsConstructorName:
159 return js.js.expressionTemplateFor("#.$typeNameProperty"); 159 return js.js.expressionTemplateFor("#.$typeNameProperty");
(...skipping 30 matching lines...) Expand all
190 default: 190 default:
191 reporter.internalError( 191 reporter.internalError(
192 NO_LOCATION_SPANNABLE, "Unhandled Builtin: $builtin"); 192 NO_LOCATION_SPANNABLE, "Unhandled Builtin: $builtin");
193 return null; 193 return null;
194 } 194 }
195 } 195 }
196 196
197 @override 197 @override
198 void invalidateCaches() {} 198 void invalidateCaches() {}
199 } 199 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698