Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: pkg/compiler/lib/src/core_types.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)
Patch Set: Updated cf. comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/constants/values.dart ('k') | pkg/compiler/lib/src/dart_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/core_types.dart
diff --git a/pkg/compiler/lib/src/core_types.dart b/pkg/compiler/lib/src/core_types.dart
index aff5fd9b17a28586846092efb88ace4eba9bc4b7..6f70cbb8bc078644ec69f1d09f5b4ab1d097095b 100644
--- a/pkg/compiler/lib/src/core_types.dart
+++ b/pkg/compiler/lib/src/core_types.dart
@@ -14,8 +14,8 @@ import 'elements/elements.dart'
LibraryElement,
Element;
-/// The core classes in Dart.
-abstract class CoreClasses {
+/// The common elements and types in Dart.
+abstract class CommonElements {
/// The `Object` class defined in 'dart:core'.
ClassElement get objectClass;
@@ -61,15 +61,12 @@ abstract class CoreClasses {
/// The `Iterable` class defined in 'dart:core';
ClassElement get iterableClass;
- /// The `Future` class defined in 'async';
+ /// The `Future` class defined in 'async';.
ClassElement get futureClass;
/// The `Stream` class defined in 'async';
ClassElement get streamClass;
-}
-/// TODO(sigmund): delete CoreClasses and merge it here.
-abstract class CommonElements extends CoreClasses {
/// The dart:core library.
LibraryElement get coreLibrary;
@@ -136,10 +133,7 @@ abstract class CommonElements extends CoreClasses {
/// The 'filled' constructor of `List`.
ConstructorElement get filledListConstructor;
-}
-/// The core types in Dart.
-abstract class CoreTypes {
/// The `Object` type defined in 'dart:core'.
InterfaceType get objectType;
@@ -194,9 +188,6 @@ abstract class CoreTypes {
/// If no type argument is provided, the canonical raw type is returned.
InterfaceType iterableType([DartType elementType]);
- /// The `Future` class declaration.
- ClassElement get futureClass;
-
/// Returns an instance of the `Future` type defined in 'dart:async' with
/// [elementType] as its type argument.
///
« no previous file with comments | « pkg/compiler/lib/src/constants/values.dart ('k') | pkg/compiler/lib/src/dart_types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698