Enable -Wundeclared-selector on ios.

Enable -Wundeclared-selector on ios.

Enables the undeclared selector warning on all ios builds.

Fixes code caught by this warning.

BUG=

Committed: https://crrev.com/83e9a66e233a40efe2c790e4df5831979bf16dcc
Cr-Commit-Position: refs/heads/master@{#440620}

[marq (ping after 24h), 2016-12-22 13:18:54]

marq@chromium.org changed reviewers:
+ dpranke@chromium.org, rohitrao@chromium.org, stkhapugin@chromium.org

[marq (ping after 24h), 2016-12-22 13:18:54]

dpranke@ build/config/

[marq (ping after 24h), 2016-12-22 13:19:15]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 13:19:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 13:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 13:38:18]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2016-12-22 14:14:18]

Fix more warnings.

[marq (ping after 24h), 2016-12-22 14:17:00]

marq@chromium.org changed reviewers:
+ rsesek@chromium.org

[marq (ping after 24h), 2016-12-22 14:17:00]

+resesek for /third_party/ocmock/

[Dirk Pranke, 2016-12-22 21:15:07]

//build/config/compiler/BUILD.gn lgtm.

[Robert Sesek, 2016-12-22 22:32:40]

LGTM

[stkhapugin, 2016-12-23 10:27:19]

lgtm

https://codereview.chromium.org/2595213003/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2595213003/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:973: if (is_ios) {
Can you ping someone in Chromium on Mac to look at this in case they want this
flag?

[marq (ping after 24h), 2016-12-23 10:33:06]

https://codereview.chromium.org/2595213003/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2595213003/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:973: if (is_ios) {
On 2016/12/23 10:27:18, stkhapugin wrote:
> Can you ping someone in Chromium on Mac to look at this in case they want this
> flag?

I will, but if the Mac code requires fixes as well, I don't want to complicate
this CL with them. So my thinking is that we can land this and start using it
for iOS, and if the Mac folks want to turn it on they can.

[marq (ping after 24h), 2016-12-23 11:37:38]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2016-12-23 11:37:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 12:38:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482493058791800,
"parent_rev": "4c4550f60df2f77127c08c892c0de0efdf69760f", "commit_rev":
"60faf6f42d4de001d519cacd91893a7c6feab275"}

[commit-bot: I haz the power, 2016-12-23 12:39:25]

Description was changed from

==========
Enable -Wundeclared-selector on ios.

Enables the undeclared selector warning on all ios builds.

Fixes code caught by this warning.

BUG=
==========

to

==========
Enable -Wundeclared-selector on ios.

Enables the undeclared selector warning on all ios builds.

Fixes code caught by this warning.

BUG=

Review-Url: https://codereview.chromium.org/2595213003
==========

[commit-bot: I haz the power, 2016-12-23 12:39:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-23 12:42:02]

Description was changed from

==========
Enable -Wundeclared-selector on ios.

Enables the undeclared selector warning on all ios builds.

Fixes code caught by this warning.

BUG=

Review-Url: https://codereview.chromium.org/2595213003
==========

to

==========
Enable -Wundeclared-selector on ios.

Enables the undeclared selector warning on all ios builds.

Fixes code caught by this warning.

BUG=

Committed: https://crrev.com/83e9a66e233a40efe2c790e4df5831979bf16dcc
Cr-Commit-Position: refs/heads/master@{#440620}
==========

[commit-bot: I haz the power, 2016-12-23 12:42:04]

Patchset 2 (id:??) landed as
https://crrev.com/83e9a66e233a40efe2c790e4df5831979bf16dcc
Cr-Commit-Position: refs/heads/master@{#440620}