Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2325)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2595213003: Enable -Wundeclared-selector on ios. (Closed)
Patch Set: Fix more warnings. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/app/application_delegate/metrics_mediator_testing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index f3a69627b3b04726b55af755978481a6a7cd2ff7..28214c87ca4ddfed2a4716e2a98d20e20eb9627c 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -970,6 +970,12 @@ config("default_warnings") {
cflags += [ "-Wpartial-availability" ]
}
+ if (is_ios) {
stkhapugin 2016/12/23 10:27:18 Can you ping someone in Chromium on Mac to look at
marq (ping after 24h) 2016/12/23 10:33:06 I will, but if the Mac code requires fixes as well
+ # When compiling Objective-C, warns if a selector named via @selector has
+ # not been defined in any visible interface.
+ cflags += [ "-Wundeclared-selector" ]
+ }
+
# Suppress warnings about ABI changes on ARM (Clang doesn't give this
# warning).
if (current_cpu == "arm" && !is_clang) {
« no previous file with comments | « no previous file | ios/chrome/app/application_delegate/metrics_mediator_testing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698