Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: ios/chrome/browser/memory/memory_debugger.mm

Issue 2595213003: Enable -Wundeclared-selector on ios. (Closed)
Patch Set: Fix more warnings. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/memory/memory_debugger.mm
diff --git a/ios/chrome/browser/memory/memory_debugger.mm b/ios/chrome/browser/memory/memory_debugger.mm
index da304df0714a5ca9805bbf42fad6c447f20137a0..6d41fbe54034c476dd4a852e6d4e5fe394e62f19 100644
--- a/ios/chrome/browser/memory/memory_debugger.mm
+++ b/ios/chrome/browser/memory/memory_debugger.mm
@@ -119,10 +119,13 @@ const CGFloat kPadding = 10;
// TODO(lliabraa): Figure out how to support memory warnings (or something
// like them) in official builds.
#if CHROMIUM_BUILD
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wundeclared-selector"
[self addButtonWithTitle:@"Trigger Memory Warning"
target:[UIApplication sharedApplication]
action:@selector(_performMemoryWarning)
withOrigin:[self originForSubviewAtIndex:index++]];
+#pragma clang diagnostic pop
#endif // CHROMIUM_BUILD
// Display a text input to set the amount of artificial memory bloat and a
@@ -504,12 +507,15 @@ const CGFloat kPadding = 10;
}
// If a valid value was found have the timer start triggering continuous
// memory warnings.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wundeclared-selector"
_memoryWarningTimer.reset(
[[NSTimer scheduledTimerWithTimeInterval:timerValue
target:[UIApplication sharedApplication]
selector:@selector(_performMemoryWarning)
userInfo:nil
repeats:YES] retain]);
+#pragma clang diagnostic push
}
#endif // CHROMIUM_BUILD

Powered by Google App Engine
This is Rietveld 408576698