Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2595213003: Enable -Wundeclared-selector on ios. (Closed)
Patch Set: Fix more warnings. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/app/application_delegate/metrics_mediator_testing.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 952 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 ] 963 ]
964 } 964 }
965 } else { 965 } else {
966 if (is_mac && !is_nacl) { 966 if (is_mac && !is_nacl) {
967 # When compiling Objective-C, warns if a method is used whose 967 # When compiling Objective-C, warns if a method is used whose
968 # availability is newer than the deployment target. This is not 968 # availability is newer than the deployment target. This is not
969 # required when compiling Chrome for iOS. 969 # required when compiling Chrome for iOS.
970 cflags += [ "-Wpartial-availability" ] 970 cflags += [ "-Wpartial-availability" ]
971 } 971 }
972 972
973 if (is_ios) {
stkhapugin 2016/12/23 10:27:18 Can you ping someone in Chromium on Mac to look at
marq (ping after 24h) 2016/12/23 10:33:06 I will, but if the Mac code requires fixes as well
974 # When compiling Objective-C, warns if a selector named via @selector has
975 # not been defined in any visible interface.
976 cflags += [ "-Wundeclared-selector" ]
977 }
978
973 # Suppress warnings about ABI changes on ARM (Clang doesn't give this 979 # Suppress warnings about ABI changes on ARM (Clang doesn't give this
974 # warning). 980 # warning).
975 if (current_cpu == "arm" && !is_clang) { 981 if (current_cpu == "arm" && !is_clang) {
976 cflags += [ "-Wno-psabi" ] 982 cflags += [ "-Wno-psabi" ]
977 } 983 }
978 984
979 if (!is_clang) { 985 if (!is_clang) {
980 cflags_cc += [ 986 cflags_cc += [
981 # See comment for -Wno-c++11-narrowing. 987 # See comment for -Wno-c++11-narrowing.
982 "-Wno-narrowing", 988 "-Wno-narrowing",
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
1639 1645
1640 if (is_ios || is_mac) { 1646 if (is_ios || is_mac) {
1641 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1647 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1642 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1648 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1643 config("enable_arc") { 1649 config("enable_arc") {
1644 common_flags = [ "-fobjc-arc" ] 1650 common_flags = [ "-fobjc-arc" ]
1645 cflags_objc = common_flags 1651 cflags_objc = common_flags
1646 cflags_objcc = common_flags 1652 cflags_objcc = common_flags
1647 } 1653 }
1648 } 1654 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/app/application_delegate/metrics_mediator_testing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698