DevTools: [Persistence] introduce badged icons instead of checkmarks

DevTools: [Persistence] introduce badged icons instead of checkmarks

This patch introduces badged icons instead of green checkmarks.
To achieve this, this CL does:
- introduce a bunch of new icons
- introduce UI.Icon.combine method, which overlays an array of icons atop
  of each other. The result of this operation is a span which has dimensions
  of the first icon.

BUG=675856
R=dgozman

Committed: https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d
Cr-Commit-Position: refs/heads/master@{#440194}

[lushnikov, 2016-12-21 00:51:30]

please, take a look

[lushnikov, 2016-12-21 00:51:35]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-21 00:52:50]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-21 02:37:29]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 02:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:40:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dgozman, 2016-12-21 02:44:40]

lgtm

https://codereview.chromium.org/2594883002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2594883002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:225:
'badge-navigator-file-sync-error': {x: -320, y: -72, width: 32, height: 24,
spritesheet: 'largeicons'},
Remove.

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:964:
defaultIcon.classList.add('icon-container');
remove?

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
(right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css:109:
display: flex;
align-items: center;

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css (right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css:77: display:
flex;
align-items: center;

[lushnikov, 2016-12-21 02:58:45]

all done, thanks!

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:964:
defaultIcon.classList.add('icon-container');
On 2016/12/21 02:44:40, dgozman wrote:
> remove?

Done.

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
(right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css:109:
display: flex;
On 2016/12/21 02:44:40, dgozman wrote:
> align-items: center;

Removed display:flex in favor of:

.devtools-link [is=ui-icon] {
    vertical-align: middle;
}

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css (right):

https://codereview.chromium.org/2594883002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css:77: display:
flex;
On 2016/12/21 02:44:40, dgozman wrote:
> align-items: center;

Done.

[lushnikov, 2016-12-21 17:57:10]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-21 17:57:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2594883002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-21 17:57:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:06:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482343030504250,
"parent_rev": "37b05ade1ed50c7beedc27f35bd9155535480935", "commit_rev":
"ce8254e32ae0188b5b5b37199fe431a3fff0fcd7"}

[commit-bot: I haz the power, 2016-12-21 20:07:08]

Description was changed from

==========
DevTools: [Persistence] introduce badged icons instead of checkmarks

This patch introduces badged icons instead of green checkmarks.
To achieve this, this CL does:
- introduce a bunch of new icons
- introduce UI.Icon.combine method, which overlays an array of icons atop
  of each other. The result of this operation is a span which has dimensions
  of the first icon.

BUG=675856
R=dgozman
==========

to

==========
DevTools: [Persistence] introduce badged icons instead of checkmarks

This patch introduces badged icons instead of green checkmarks.
To achieve this, this CL does:
- introduce a bunch of new icons
- introduce UI.Icon.combine method, which overlays an array of icons atop
  of each other. The result of this operation is a span which has dimensions
  of the first icon.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2594883002
==========

[commit-bot: I haz the power, 2016-12-21 20:07:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-21 20:09:11]

Description was changed from

==========
DevTools: [Persistence] introduce badged icons instead of checkmarks

This patch introduces badged icons instead of green checkmarks.
To achieve this, this CL does:
- introduce a bunch of new icons
- introduce UI.Icon.combine method, which overlays an array of icons atop
  of each other. The result of this operation is a span which has dimensions
  of the first icon.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2594883002
==========

to

==========
DevTools: [Persistence] introduce badged icons instead of checkmarks

This patch introduces badged icons instead of green checkmarks.
To achieve this, this CL does:
- introduce a bunch of new icons
- introduce UI.Icon.combine method, which overlays an array of icons atop
  of each other. The result of this operation is a span which has dimensions
  of the first icon.

BUG=675856
R=dgozman

Committed: https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d
Cr-Commit-Position: refs/heads/master@{#440194}
==========

[commit-bot: I haz the power, 2016-12-21 20:09:12]

Patchset 6 (id:??) landed as
https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d
Cr-Commit-Position: refs/heads/master@{#440194}