Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2594883002: DevTools: [Persistence] introduce badged icons instead of checkmarks (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
index 1a20d3f672e16bd1405780e59bad812977a38ac7..85274ea8313e4d4dd02c6231eda7fafbfc05604a 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
@@ -357,21 +357,21 @@ InspectorTest.expandAndDumpEventListeners = function(eventListenersView, callbac
InspectorTest.addSniffer(Components.EventListenersView.prototype, "_eventListenersArrivedForTest", listenersArrived);
}
-InspectorTest.dumpNavigatorView = function(navigatorView)
+InspectorTest.dumpNavigatorView = function(navigatorView, dumpIcons)
{
dumpNavigatorTreeOutline(navigatorView._scriptsTree);
function dumpNavigatorTreeElement(prefix, treeElement)
{
- var titleText = treeElement.title;
- if (treeElement._trailingIconsElement) {
- var iconTypes = [];
- for (var icon = treeElement._trailingIconsElement.firstChild; icon; icon = icon.nextSibling) {
- iconTypes.push(icon._iconType);
- }
+ var titleText = '';
+ if (treeElement._leadingIconsElement && dumpIcons) {
+ var icons = treeElement._leadingIconsElement.querySelectorAll('[is=ui-icon]');
+ icons = Array.prototype.slice.call(icons);
+ var iconTypes = icons.map(icon => icon._iconType);
if (iconTypes.length)
- titleText = titleText + " [" + iconTypes.join(", ") + "]";
+ titleText = titleText + "[" + iconTypes.join(", ") + "] ";
}
+ titleText += treeElement.title;
if (treeElement._nodeType === Sources.NavigatorView.Types.FileSystem || treeElement._nodeType === Sources.NavigatorView.Types.FileSystemFolder) {
var hasMappedFiles = treeElement.listItemElement.classList.contains("has-mapped-files");
if (!hasMappedFiles)
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698