third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js - Issue 2594883002: DevTools: [Persistence] introduce badged icons instead of checkmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2594883002: DevTools: [Persistence] introduce badged icons instead of checkmarks (Closed)

Patch Set: address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

index 1a8526d8fe07500c1734acd0ba6a79c024f6e34c..1410bfe8e381ad0b3b500df67ff83bc2c63fda28 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

@@ -537,10 +537,8 @@ Sources.TabbedEditorContainer = class extends Common.Object {

if (Persistence.persistence.hasUnsavedCommittedChanges(uiSourceCode)) {

icon = UI.Icon.create('smallicon-warning');

icon.title = Common.UIString('Changes to this file were not saved to file system.');

- } else if (Runtime.experiments.isEnabled('persistence2') && Persistence.persistence.binding(uiSourceCode)) {

- var binding = Persistence.persistence.binding(uiSourceCode);

- icon = UI.Icon.create('smallicon-green-checkmark');

- icon.title = Persistence.PersistenceUtils.tooltipForUISourceCode(binding.fileSystem);

+ } else {

+ icon = Persistence.PersistenceUtils.iconForUISourceCode(uiSourceCode);

}

this._tabbedPane.setTabIcon(tabId, icon);

}