DevTools: move throttling options into the secondary toolbar in Performance tab.

DevTools: move throttling options into the secondary toolbar in Performance tab.

Committed: https://crrev.com/58df86c7b9a3e177296b289c1f3d20a21b8983f1
Cr-Commit-Position: refs/heads/master@{#440050}

[pfeldman, 2016-12-20 23:44:06]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org

[caseq, 2016-12-21 00:22:45]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-12-21 00:22:45]

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
(right):

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js:84:
if (i === groups.length - 1) {
Don't you want this to be the last?

[caseq, 2016-12-21 00:35:29]

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:125:
this._configureThrottlingSetting =
Common.settings.createSetting('timelineConfigureThrottling', false);
This does not have to be a member.

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:142:
this._configureThrottlingSetting.addChangeListener(this._updateThrottlingToolbarVisibility.bind(this));
nit: move up to where the setting is created.

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:323:
this._panelToolbar.appendText(Common.UIString('Network:'));
Why do we add Network label before memory checkbox?!

[alph, 2016-12-21 00:37:11]

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2597553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:138: var
hideToolbarItem = new UI.ToolbarButton(Common.UIString('Disable throttling'),
'largeicon-delete');
Does it really disable throttling?

[pfeldman, 2016-12-21 00:43:08]

All done.

[caseq, 2016-12-21 00:44:31]

lgtm

[pfeldman, 2016-12-21 00:47:28]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:52:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-12-21 03:01:32]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:02:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:07:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-12-21 06:42:57]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-12-21 06:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2597553002/#ps60001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-12-21 06:43:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 08:12:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482302577900190,
"parent_rev": "8990522057cab68ed8dd53184ba6505265ac87ab", "commit_rev":
"2687df56bf27f1f14837b9bf3f9324907968aa47"}

[commit-bot: I haz the power, 2016-12-21 08:13:10]

Description was changed from

==========
DevTools: move throttling options into the secondary toolbar in Performance tab.
==========

to

==========
DevTools: move throttling options into the secondary toolbar in Performance tab.

Review-Url: https://codereview.chromium.org/2597553002
==========

[commit-bot: I haz the power, 2016-12-21 08:13:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-21 08:15:06]

Description was changed from

==========
DevTools: move throttling options into the secondary toolbar in Performance tab.

Review-Url: https://codereview.chromium.org/2597553002
==========

to

==========
DevTools: move throttling options into the secondary toolbar in Performance tab.

Committed: https://crrev.com/58df86c7b9a3e177296b289c1f3d20a21b8983f1
Cr-Commit-Position: refs/heads/master@{#440050}
==========

[commit-bot: I haz the power, 2016-12-21 08:15:07]

Patchset 4 (id:??) landed as
https://crrev.com/58df86c7b9a3e177296b289c1f3d20a21b8983f1
Cr-Commit-Position: refs/heads/master@{#440050}