Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2594683002: [Turbofan] Add native ARM support for Simd Float32x4 operations. (Closed)

Created:
4 years ago by bbudge
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add native ARM support for Simd Float32x4 operations. - Adds Float32x4 Abs, Neg, Equal, NotEqual. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2594683002 Cr-Commit-Position: refs/heads/master@{#41870} Committed: https://chromium.googlesource.com/v8/v8/+/5354e28c8dbf40239f842bfed5fff72c72e9ddf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -8 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +72 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bbudge
4 years ago (2016-12-20 13:49:16 UTC) #4
bbudge
+Rodolph for src/compiler/arm/code-generator-arm.cc.
4 years ago (2016-12-20 13:50:15 UTC) #6
Rodolph Perfetta
On 2016/12/20 13:50:15, bbudge wrote: > +Rodolph for src/compiler/arm/code-generator-arm.cc. code-generator-arm.cc looks good.
4 years ago (2016-12-20 14:23:30 UTC) #9
titzer
On 2016/12/20 14:23:30, Rodolph Perfetta wrote: > On 2016/12/20 13:50:15, bbudge wrote: > > +Rodolph ...
4 years ago (2016-12-20 15:40:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594683002/1
4 years ago (2016-12-20 16:48:16 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 16:50:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5354e28c8dbf40239f842bfed5fff72c72e...

Powered by Google App Engine
This is Rietveld 408576698