[Turbofan] Add native ARM support for Simd Float32x4 operations.

test/cctest/wasm/test-run-wasm-simd.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/wasm/wasm-macro-gen.h"
 
 #include "test/cctest/cctest.h"
 #include "test/cctest/compiler/value-helper.h"
 #include "test/cctest/wasm/wasm-run-utils.h"
 
 using namespace v8::base;
 using namespace v8::internal;
 using namespace v8::internal::compiler;
 using namespace v8::internal::wasm;
 
 namespace {
 
+typedef float (*FloatUnOp)(float);
 typedef float (*FloatBinOp)(float, float);
+typedef int32_t (*FloatCompareOp)(float, float);
 typedef int32_t (*Int32BinOp)(int32_t, int32_t);
 
 template <typename T>
+T Negate(T a) {
+  return -a;
+}
+
+template <typename T>
 T Add(T a, T b) {
   return a + b;
 }
 
 template <typename T>
 T Sub(T a, T b) {
   return a - b;
 }
 
 template <typename T>
 int32_t Equal(T a, T b) {
   return a == b ? 0xFFFFFFFF : 0;
 }
 
 template <typename T>
 int32_t NotEqual(T a, T b) {
   return a != b ? 0xFFFFFFFF : 0;
 }
 
+#if V8_TARGET_ARCH_ARM
+int32_t Equal(float a, float b) { return a == b ? 0xFFFFFFFF : 0; }
+
+int32_t NotEqual(float a, float b) { return a != b ? 0xFFFFFFFF : 0; }
+#endif  // V8_TARGET_ARCH_ARM
+
 }  // namespace
 
 // TODO(gdeepti): These are tests using sample values to verify functional
 // correctness of opcodes, add more tests for a range of values and macroize
 // tests.
 
 // TODO(bbudge) Figure out how to compare floats in Wasm code that can handle
 // NaNs. For now, our tests avoid using NaNs.
 #define WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lane_value, lane_index) \
   WASM_IF(WASM_##LANE_TYPE##_NE(WASM_GET_LOCAL(lane_value),                  \
@@ skipping 122 matching lines @@
                                                         WASM_GET_LOCAL(src2))),
             WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val2, 0),
             WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val1, 1),
             WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val1, 2),
             WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val2, 3),
             WASM_RETURN1(WASM_ONE)));
 
   CHECK_EQ(1, r.Call(0x1234, 0x5678));
 }
 
-static void RunF32x4BinopTest(WasmOpcode simd_op, FloatBinOp expected_op) {
+void RunF32x4UnOpTest(WasmOpcode simd_op, FloatUnOp expected_op) {
+  FLAG_wasm_simd_prototype = true;
+  WasmRunner<int32_t, float, float> r(kExecuteCompiled);
+  byte a = 0;
+  byte expected = 1;
+  byte simd = r.AllocateLocal(kAstS128);
+  BUILD(r, WASM_BLOCK(
+               WASM_SET_LOCAL(simd, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))),
+               WASM_SET_LOCAL(
+                   simd, WASM_SIMD_UNOP(simd_op & 0xffu, WASM_GET_LOCAL(simd))),
+               WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd, expected),
+               WASM_RETURN1(WASM_ONE)));
+
+  FOR_FLOAT32_INPUTS(i) {
+    if (std::isnan(*i)) continue;
+    CHECK_EQ(1, r.Call(*i, expected_op(*i)));
+  }
+}
+
+WASM_EXEC_TEST(F32x4Abs) { RunF32x4UnOpTest(kExprF32x4Abs, std::abs); }
+WASM_EXEC_TEST(F32x4Neg) { RunF32x4UnOpTest(kExprF32x4Neg, Negate); }
+
+void RunF32x4BinOpTest(WasmOpcode simd_op, FloatBinOp expected_op) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, float, float, float> r(kExecuteCompiled);
   byte a = 0;
   byte b = 1;
   byte expected = 2;
   byte simd0 = r.AllocateLocal(kAstS128);
   byte simd1 = r.AllocateLocal(kAstS128);
   BUILD(r, WASM_BLOCK(
                WASM_SET_LOCAL(simd0, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))),
                WASM_SET_LOCAL(simd1, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(b))),
                WASM_SET_LOCAL(simd1, WASM_SIMD_BINOP(simd_op & 0xffu,
                                                      WASM_GET_LOCAL(simd0),
                                                      WASM_GET_LOCAL(simd1))),
                WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd1, expected),
                WASM_RETURN1(WASM_ONE)));
 
   FOR_FLOAT32_INPUTS(i) {
     if (std::isnan(*i)) continue;
     FOR_FLOAT32_INPUTS(j) {
       if (std::isnan(*j)) continue;
       CHECK_EQ(1, r.Call(*i, *j, expected_op(*i, *j)));
     }
   }
 }
 
-WASM_EXEC_TEST(F32x4Add) { RunF32x4BinopTest(kExprF32x4Add, Add); }
-WASM_EXEC_TEST(F32x4Sub) { RunF32x4BinopTest(kExprF32x4Sub, Sub); }
+WASM_EXEC_TEST(F32x4Add) { RunF32x4BinOpTest(kExprF32x4Add, Add); }
+WASM_EXEC_TEST(F32x4Sub) { RunF32x4BinOpTest(kExprF32x4Sub, Sub); }
+
+void RunF32x4CompareOpTest(WasmOpcode simd_op, FloatCompareOp expected_op) {
+  FLAG_wasm_simd_prototype = true;
+  WasmRunner<int32_t, float, float, int32_t> r(kExecuteCompiled);
+  byte a = 0;
+  byte b = 1;
+  byte expected = 2;
+  byte simd0 = r.AllocateLocal(kAstS128);
+  byte simd1 = r.AllocateLocal(kAstS128);
+  BUILD(r, WASM_BLOCK(
+               WASM_SET_LOCAL(simd0, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))),
+               WASM_SET_LOCAL(simd1, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(b))),
+               WASM_SET_LOCAL(simd1, WASM_SIMD_BINOP(simd_op & 0xffu,
+                                                     WASM_GET_LOCAL(simd0),
+                                                     WASM_GET_LOCAL(simd1))),
+               WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected),
+               WASM_RETURN1(WASM_ONE)));
+
+  FOR_FLOAT32_INPUTS(i) {
+    if (std::isnan(*i)) continue;
+    FOR_FLOAT32_INPUTS(j) {
+      if (std::isnan(*j)) continue;
+      CHECK_EQ(1, r.Call(*i, *j, expected_op(*i, *j)));
+    }
+  }
+}
+
+WASM_EXEC_TEST(F32x4Equal) { RunF32x4CompareOpTest(kExprF32x4Eq, Equal); }
+WASM_EXEC_TEST(F32x4NotEqual) { RunF32x4CompareOpTest(kExprF32x4Ne, NotEqual); }
 #endif  // V8_TARGET_ARCH_ARM
 
 WASM_EXEC_TEST(I32x4Splat) {
   FLAG_wasm_simd_prototype = true;
 
   // Store SIMD value in a local variable, use extract lane to check lane values
   // This test is not a test for ExtractLane as Splat does not create
   // interesting SIMD values.
   //
   // SetLocal(1, I32x4Splat(Local(0)));
@@ skipping 109 matching lines @@
                WASM_RETURN1(WASM_ONE)));
 
   FOR_FLOAT32_INPUTS(i) {
     int32_t signed_value = ConvertToInt(*i, false);
     int32_t unsigned_value = ConvertToInt(*i, true);
     CHECK_EQ(1, r.Call(*i, signed_value, unsigned_value));
   }
 }
 #endif  // V8_TARGET_ARCH_ARM
 
-static void RunI32x4BinopTest(WasmOpcode simd_op, Int32BinOp expected_op) {
+void RunI32x4BinOpTest(WasmOpcode simd_op, Int32BinOp expected_op) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, int32_t, int32_t, int32_t> r(kExecuteCompiled);
   byte a = 0;
   byte b = 1;
   byte expected = 2;
   byte simd0 = r.AllocateLocal(kAstS128);
   byte simd1 = r.AllocateLocal(kAstS128);
   BUILD(r, WASM_BLOCK(
                WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))),
                WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(b))),
                WASM_SET_LOCAL(simd1, WASM_SIMD_BINOP(simd_op & 0xffu,
                                                      WASM_GET_LOCAL(simd0),
                                                      WASM_GET_LOCAL(simd1))),
                WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected),
                WASM_RETURN1(WASM_ONE)));
 
   FOR_INT32_INPUTS(i) {
     FOR_INT32_INPUTS(j) { CHECK_EQ(1, r.Call(*i, *j, expected_op(*i, *j))); }
   }
 }
 
-WASM_EXEC_TEST(I32x4Add) { RunI32x4BinopTest(kExprI32x4Add, Add); }
+WASM_EXEC_TEST(I32x4Add) { RunI32x4BinOpTest(kExprI32x4Add, Add); }
 
-WASM_EXEC_TEST(I32x4Sub) { RunI32x4BinopTest(kExprI32x4Sub, Sub); }
+WASM_EXEC_TEST(I32x4Sub) { RunI32x4BinOpTest(kExprI32x4Sub, Sub); }
 
 #if V8_TARGET_ARCH_ARM
-WASM_EXEC_TEST(I32x4Equal) { RunI32x4BinopTest(kExprI32x4Eq, Equal); }
+WASM_EXEC_TEST(I32x4Equal) { RunI32x4BinOpTest(kExprI32x4Eq, Equal); }
 
-WASM_EXEC_TEST(I32x4NotEqual) { RunI32x4BinopTest(kExprI32x4Ne, NotEqual); }
+WASM_EXEC_TEST(I32x4NotEqual) { RunI32x4BinOpTest(kExprI32x4Ne, NotEqual); }
 #endif  // V8_TARGET_ARCH_ARM