mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin

Committed: https://crrev.com/c17a15dfa5b357271cd283523a868688415ef919
Cr-Commit-Position: refs/heads/master@{#440084}

[blundell, 2016-12-20 09:38:50]

Description was changed from

==========
mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.
==========

to

==========
mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[blundell, 2016-12-20 10:17:28]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:17:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-12-20 10:18:12]

Description was changed from

==========
mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-12-20 12:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 12:49:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[blundell, 2016-12-20 14:23:28]

blundell@chromium.org changed reviewers:
+ yzshen@chromium.org

[blundell, 2016-12-20 14:23:29]

The WebUIMojoEndToEndPing test has been happening flakily on that bot, looking
through the recent history of the bot.

[yzshen1, 2016-12-20 17:37:09]

LGTM with one nit

https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/interface_request.h (right):

https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/interface_request.h:37: // MakeRequest(InterfacePtr)
below.
nit: InterfacePtr is not the exact parameter type.

[yzshen1, 2016-12-20 19:13:40]

On 2016/12/20 17:37:09, yzshen1 wrote:
> LGTM with one nit
> 
>
https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/interface_request.h (right):
> 
>
https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/interface_request.h:37: // MakeRequest(InterfacePtr)
> below.
> nit: InterfacePtr is not the exact parameter type.

Oh, and if you believe WebUIMojoEndToEndPing is flaky, would you please file a
bug for it?
Thanks!

[yzshen1, 2016-12-20 20:11:24]

On 2016/12/20 19:13:40, yzshen1 wrote:
> On 2016/12/20 17:37:09, yzshen1 wrote:
> > LGTM with one nit
> > 
> >
>
https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
> > File mojo/public/cpp/bindings/interface_request.h (right):
> > 
> >
>
https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
> > mojo/public/cpp/bindings/interface_request.h:37: //
MakeRequest(InterfacePtr)
> > below.
> > nit: InterfacePtr is not the exact parameter type.
> 
> Oh, and if you believe WebUIMojoEndToEndPing is flaky, would you please file a
> bug for it?
> Thanks!

Never mind, the system has automatically filed 676071

[blundell, 2016-12-21 11:49:47]

Description was changed from

==========
mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[blundell, 2016-12-21 11:51:02]

Thanks!

https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/interface_request.h (right):

https://codereview.chromium.org/2592623002/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/interface_request.h:37: // MakeRequest(InterfacePtr)
below.
On 2016/12/20 17:37:09, yzshen1 wrote:
> nit: InterfacePtr is not the exact parameter type.

Done.

[blundell, 2016-12-21 11:51:47]

Description was changed from

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin
==========

[blundell, 2016-12-21 11:51:47]

blundell@chromium.org changed reviewers:
+ darin@chromium.org

[blundell, 2016-12-21 11:52:05]

TBR=darin for everything outside //mojo

[blundell, 2016-12-21 11:52:12]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-12-21 11:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2592623002/#ps40001
(title: "Rebase + response to review")

[commit-bot: I haz the power, 2016-12-21 11:52:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 13:52:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482321132575530,
"parent_rev": "627440e5fe79e70e525184e0f04a4948bad7e2ed", "commit_rev":
"59eee905aec4e872e9d7e41d7dd2e91ceea15c89"}

[commit-bot: I haz the power, 2016-12-21 13:52:38]

Description was changed from

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin
==========

to

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin

Review-Url: https://codereview.chromium.org/2592623002
==========

[commit-bot: I haz the power, 2016-12-21 13:52:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-21 13:54:51]

Description was changed from

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin

Review-Url: https://codereview.chromium.org/2592623002
==========

to

==========
Mojo: Introduce InterfaceRequest ctor that takes in InterfacePtr*

In
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided to introduce an InterfaceRequest constructor that takes in an
InterfacePtr* and binds to it on a new pipe (i.e., the same functionality
as mojo::MakeRequest(InterfacePtr*)). The primary use case is to replace
lines like:

FooRequest request = mojo::MakeRequest(&foo_ptr);

with:

FooRequest request(&foo_ptr);

This CL does the following:

(1) Introduces the new constructor.
(2) Changes mojo::MakeRequest(InterfacePtr*) to be implemented via this
    constructor.
(3) Performs the above-mentioned conversion across the codebase.

Note that it is not possible to use "auto" with this constructor; replacing
FooRequest with auto in the above construction will cause the compiler to
infer the type to be FooPtr*.

A followup will make a similar change to AssociatedInterfaceRequest.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin

Committed: https://crrev.com/c17a15dfa5b357271cd283523a868688415ef919
Cr-Commit-Position: refs/heads/master@{#440084}
==========

[commit-bot: I haz the power, 2016-12-21 13:54:52]

Patchset 3 (id:??) landed as
https://crrev.com/c17a15dfa5b357271cd283523a868688415ef919
Cr-Commit-Position: refs/heads/master@{#440084}