mojo/public/cpp/bindings/tests/handle_passing_unittest.cc - Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr* (Closed)

Patch Set: Rebase + response to review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

index 9d31620628cc9ef1bc059a2455ac61ef01fc0f0e..fcdebda30997f75601ca7c697242baa3d69b84d8 100644

--- a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

@@ -327,7 +327,7 @@ TEST_F(HandlePassingTest, CreateNamedObject) {

sample::NamedObjectPtr object1;

EXPECT_FALSE(object1);

- InterfaceRequest<sample::NamedObject> object1_request = MakeRequest(&object1);

+ InterfaceRequest<sample::NamedObject> object1_request(&object1);

EXPECT_TRUE(object1_request.is_pending());

factory->CreateNamedObject(std::move(object1_request));

EXPECT_FALSE(object1_request.is_pending()); // We've passed the request.