chrome/gpu/gpu_arc_video_service.cc - Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/gpu/gpu_arc_video_service.cc

Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr* (Closed)

Patch Set: Rebase + response to review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/gpu/gpu_arc_video_service.cc

diff --git a/chrome/gpu/gpu_arc_video_service.cc b/chrome/gpu/gpu_arc_video_service.cc

index 822566fe562fa760e3636daf69ed6dab37478a5c..6bd5fd551875e5a47a1dbc9c16c261eaba0eaa36 100644

--- a/chrome/gpu/gpu_arc_video_service.cc

+++ b/chrome/gpu/gpu_arc_video_service.cc

@@ -136,8 +136,7 @@ void GpuArcVideoService::DeprecatedConnect(

service->client_.set_connection_error_handler(base::Bind(&OnConnectionError));

::arc::mojom::VideoAcceleratorServicePtr service_proxy;

- ::arc::mojom::VideoAcceleratorServiceRequest request =

- mojo::MakeRequest(&service_proxy);

+ ::arc::mojom::VideoAcceleratorServiceRequest request(&service_proxy);

service->client_->DeprecatedInit(std::move(service_proxy));

auto binding = mojo::MakeStrongBinding(std::move(service),