services/navigation/view_impl.cc - Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/navigation/view_impl.cc

Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr* (Closed)

Patch Set: Rebase + response to review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/navigation/view_impl.cc

diff --git a/services/navigation/view_impl.cc b/services/navigation/view_impl.cc

index 83c28b66c2edce50266678448f2a8310b3632259..812bb60bf5e242d66f50d9bb14e7f0d5dc02d827 100644

--- a/services/navigation/view_impl.cc

+++ b/services/navigation/view_impl.cc

@@ -148,7 +148,7 @@ void ViewImpl::AddNewContents(content::WebContents* source,

bool* was_blocked) {

mojom::ViewClientPtr client;

mojom::ViewPtr view;

- mojom::ViewRequest view_request = MakeRequest(&view);

+ mojom::ViewRequest view_request(&view);

client_->ViewCreated(std::move(view), MakeRequest(&client),

disposition == WindowOpenDisposition::NEW_POPUP,

initial_rect, user_gesture);