Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2591823003: Remove ChromeBrowserProvider::RegisterProfilePrefs(). (Closed)

Created:
3 years, 12 months ago by sdefresne
Modified:
3 years, 12 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeBrowserProvider::RegisterProfilePrefs(). The sole implementation can now be inlined as the called code has been upstreamed, remove the method. BUG=676278 Committed: https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27 Cr-Commit-Position: refs/heads/master@{#440197}

Patch Set 1 #

Patch Set 2 : Fix multiple registration of preferences. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -118 lines) Patch
M ios/chrome/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.mm View 2 chunks +0 lines, -10 lines 0 comments Download
M ios/chrome/browser/prefs/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 4 chunks +7 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 1 3 chunks +77 lines, -78 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm View 1 2 chunks +1 line, -10 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 12 months ago (2016-12-21 14:34:44 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 12 months ago (2016-12-21 14:38:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591823003/1
3 years, 12 months ago (2016-12-21 14:46:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/127877)
3 years, 12 months ago (2016-12-21 15:06:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591823003/20001
3 years, 12 months ago (2016-12-21 18:44:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-21 20:16:28 UTC) #17
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 20:21:09 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c9f321b835f2839bfc066a20932fd9f92dd8b27
Cr-Commit-Position: refs/heads/master@{#440197}

Powered by Google App Engine
This is Rietveld 408576698