Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/ui/bookmarks/BUILD.gn

Issue 2591823003: Remove ChromeBrowserProvider::RegisterProfilePrefs(). (Closed)
Patch Set: Fix multiple registration of preferences. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/prefs/browser_prefs.mm ('k') | ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/bookmarks/BUILD.gn
diff --git a/ios/chrome/browser/ui/bookmarks/BUILD.gn b/ios/chrome/browser/ui/bookmarks/BUILD.gn
index 627dca37448593cef1b6e24f80f7304a2bd46f19..f1fefb84fa2e17d30ecc533f67b0f8447b824e75 100644
--- a/ios/chrome/browser/ui/bookmarks/BUILD.gn
+++ b/ios/chrome/browser/ui/bookmarks/BUILD.gn
@@ -2,83 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-bundle_data("resources") {
- sources = [
- "resources/bookmark_bar_innershadow.png",
- "resources/bookmark_bar_innershadow@2x.png",
- "resources/bookmark_bar_innershadow@3x.png",
- "resources/bookmark_bar_shadow.png",
- "resources/bookmark_bar_shadow@2x.png",
- "resources/bookmark_bar_shadow@3x.png",
- "resources/bookmark_black_delete.png",
- "resources/bookmark_black_delete@2x.png",
- "resources/bookmark_black_delete@3x.png",
- "resources/bookmark_black_edit.png",
- "resources/bookmark_black_edit@2x.png",
- "resources/bookmark_black_edit@3x.png",
- "resources/bookmark_black_move.png",
- "resources/bookmark_black_move@2x.png",
- "resources/bookmark_black_move@3x.png",
- "resources/bookmark_black_select.png",
- "resources/bookmark_black_select@2x.png",
- "resources/bookmark_black_select@3x.png",
- "resources/bookmark_blue_check.png",
- "resources/bookmark_blue_check@2x.png",
- "resources/bookmark_blue_check@3x.png",
- "resources/bookmark_blue_folder.png",
- "resources/bookmark_blue_folder@2x.png",
- "resources/bookmark_blue_folder@3x.png",
- "resources/bookmark_blue_star.png",
- "resources/bookmark_blue_star@2x.png",
- "resources/bookmark_blue_star@3x.png",
- "resources/bookmark_gray_back.png",
- "resources/bookmark_gray_back@2x.png",
- "resources/bookmark_gray_back@3x.png",
- "resources/bookmark_gray_check.png",
- "resources/bookmark_gray_check@2x.png",
- "resources/bookmark_gray_check@3x.png",
- "resources/bookmark_gray_close.png",
- "resources/bookmark_gray_close@2x.png",
- "resources/bookmark_gray_close@3x.png",
- "resources/bookmark_gray_edit.png",
- "resources/bookmark_gray_edit@2x.png",
- "resources/bookmark_gray_edit@3x.png",
- "resources/bookmark_gray_folder.png",
- "resources/bookmark_gray_folder@2x.png",
- "resources/bookmark_gray_folder@3x.png",
- "resources/bookmark_gray_menu.png",
- "resources/bookmark_gray_menu@2x.png",
- "resources/bookmark_gray_menu@3x.png",
- "resources/bookmark_gray_new_folder.png",
- "resources/bookmark_gray_new_folder@2x.png",
- "resources/bookmark_gray_new_folder@3x.png",
- "resources/bookmark_gray_star.png",
- "resources/bookmark_gray_star@2x.png",
- "resources/bookmark_gray_star@3x.png",
- "resources/bookmark_gray_star_large.png",
- "resources/bookmark_gray_star_large@2x.png",
- "resources/bookmark_gray_star_large@3x.png",
- "resources/bookmark_more.png",
- "resources/bookmark_more@2x.png",
- "resources/bookmark_more@3x.png",
- "resources/bookmark_white_close.png",
- "resources/bookmark_white_close@2x.png",
- "resources/bookmark_white_close@3x.png",
- "resources/bookmark_white_delete.png",
- "resources/bookmark_white_delete@2x.png",
- "resources/bookmark_white_delete@3x.png",
- "resources/bookmark_white_edit.png",
- "resources/bookmark_white_edit@2x.png",
- "resources/bookmark_white_edit@3x.png",
- "resources/bookmark_white_move.png",
- "resources/bookmark_white_move@2x.png",
- "resources/bookmark_white_move@3x.png",
- ]
- outputs = [
- "{{bundle_resources_dir}}/{{source_file_part}}",
- ]
-}
-
source_set("bookmarks") {
sources = [
"bookmark_all_collection_view.h",
@@ -213,7 +136,6 @@ source_set("unit_tests") {
"//base",
"//components/bookmarks/browser",
"//components/bookmarks/test",
- "//components/sync_preferences:test_support",
"//ios/chrome/browser",
"//ios/chrome/browser/bookmarks",
"//ios/chrome/browser/browser_state:test_support",
@@ -255,3 +177,80 @@ source_set("eg_tests") {
"XCTest.framework",
]
}
+
+bundle_data("resources") {
+ sources = [
+ "resources/bookmark_bar_innershadow.png",
+ "resources/bookmark_bar_innershadow@2x.png",
+ "resources/bookmark_bar_innershadow@3x.png",
+ "resources/bookmark_bar_shadow.png",
+ "resources/bookmark_bar_shadow@2x.png",
+ "resources/bookmark_bar_shadow@3x.png",
+ "resources/bookmark_black_delete.png",
+ "resources/bookmark_black_delete@2x.png",
+ "resources/bookmark_black_delete@3x.png",
+ "resources/bookmark_black_edit.png",
+ "resources/bookmark_black_edit@2x.png",
+ "resources/bookmark_black_edit@3x.png",
+ "resources/bookmark_black_move.png",
+ "resources/bookmark_black_move@2x.png",
+ "resources/bookmark_black_move@3x.png",
+ "resources/bookmark_black_select.png",
+ "resources/bookmark_black_select@2x.png",
+ "resources/bookmark_black_select@3x.png",
+ "resources/bookmark_blue_check.png",
+ "resources/bookmark_blue_check@2x.png",
+ "resources/bookmark_blue_check@3x.png",
+ "resources/bookmark_blue_folder.png",
+ "resources/bookmark_blue_folder@2x.png",
+ "resources/bookmark_blue_folder@3x.png",
+ "resources/bookmark_blue_star.png",
+ "resources/bookmark_blue_star@2x.png",
+ "resources/bookmark_blue_star@3x.png",
+ "resources/bookmark_gray_back.png",
+ "resources/bookmark_gray_back@2x.png",
+ "resources/bookmark_gray_back@3x.png",
+ "resources/bookmark_gray_check.png",
+ "resources/bookmark_gray_check@2x.png",
+ "resources/bookmark_gray_check@3x.png",
+ "resources/bookmark_gray_close.png",
+ "resources/bookmark_gray_close@2x.png",
+ "resources/bookmark_gray_close@3x.png",
+ "resources/bookmark_gray_edit.png",
+ "resources/bookmark_gray_edit@2x.png",
+ "resources/bookmark_gray_edit@3x.png",
+ "resources/bookmark_gray_folder.png",
+ "resources/bookmark_gray_folder@2x.png",
+ "resources/bookmark_gray_folder@3x.png",
+ "resources/bookmark_gray_menu.png",
+ "resources/bookmark_gray_menu@2x.png",
+ "resources/bookmark_gray_menu@3x.png",
+ "resources/bookmark_gray_new_folder.png",
+ "resources/bookmark_gray_new_folder@2x.png",
+ "resources/bookmark_gray_new_folder@3x.png",
+ "resources/bookmark_gray_star.png",
+ "resources/bookmark_gray_star@2x.png",
+ "resources/bookmark_gray_star@3x.png",
+ "resources/bookmark_gray_star_large.png",
+ "resources/bookmark_gray_star_large@2x.png",
+ "resources/bookmark_gray_star_large@3x.png",
+ "resources/bookmark_more.png",
+ "resources/bookmark_more@2x.png",
+ "resources/bookmark_more@3x.png",
+ "resources/bookmark_white_close.png",
+ "resources/bookmark_white_close@2x.png",
+ "resources/bookmark_white_close@3x.png",
+ "resources/bookmark_white_delete.png",
+ "resources/bookmark_white_delete@2x.png",
+ "resources/bookmark_white_delete@3x.png",
+ "resources/bookmark_white_edit.png",
+ "resources/bookmark_white_edit@2x.png",
+ "resources/bookmark_white_edit@3x.png",
+ "resources/bookmark_white_move.png",
+ "resources/bookmark_white_move@2x.png",
+ "resources/bookmark_white_move@3x.png",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
+ ]
+}
« no previous file with comments | « ios/chrome/browser/prefs/browser_prefs.mm ('k') | ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698