Remove ChromeBrowserProvider::CreateInfoBarView() method.

Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278
Committed: https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b
Cr-Commit-Position: refs/heads/master@{#440090}

[sdefresne, 2016-12-21 12:01:02]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 12:01:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-21 12:08:35]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-21 12:08:36]

Please take a look and send to CQ if LGTY.

[commit-bot: I haz the power, 2016-12-21 12:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 12:59:39]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-12-21 14:07:46]

Description was changed from

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infogars/.

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278
==========

[rohitrao (ping after 24h), 2016-12-21 14:15:00]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-12-21 14:15:01]

lgtm

We may also want to get rid of the InfoBarViewProtocol and have callers use
InfoBarView directly.  I'm not sure the protocol adds any value anymore -- it
was mainly needed when the actual implementation was still downstream.

https://codereview.chromium.org/2596813002/diff/1/ios/chrome/browser/ui/infob...
File ios/chrome/browser/ui/infobars/BUILD.gn (right):

https://codereview.chromium.org/2596813002/diff/1/ios/chrome/browser/ui/infob...
ios/chrome/browser/ui/infobars/BUILD.gn:19:
"//ios/chrome/browser/ui/infobars:resources",
This can be :resources.

[commit-bot: I haz the power, 2016-12-21 14:15:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 14:20:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482329700303650, "parent_rev":
"8f46892a53c1c7c0074bff6bf21d6aa1363daf8d", "commit_rev":
"632e7f653b6ada11b32941329fcf97ab9c33021c"}

[commit-bot: I haz the power, 2016-12-21 14:21:13]

Description was changed from

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278

Review-Url: https://codereview.chromium.org/2596813002
==========

[commit-bot: I haz the power, 2016-12-21 14:21:14]

Committed patchset #1 (id:1)

[sdefresne, 2016-12-21 14:22:30]

On 2016/12/21 14:15:01, rohitrao wrote:
> lgtm
> 
> We may also want to get rid of the InfoBarViewProtocol and have callers use
> InfoBarView directly.  I'm not sure the protocol adds any value anymore -- it
> was mainly needed when the actual implementation was still downstream.

I agree (this is what I'm doing now).

>
https://codereview.chromium.org/2596813002/diff/1/ios/chrome/browser/ui/infob...
> File ios/chrome/browser/ui/infobars/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2596813002/diff/1/ios/chrome/browser/ui/infob...
> ios/chrome/browser/ui/infobars/BUILD.gn:19:
> "//ios/chrome/browser/ui/infobars:resources",
> This can be :resources.

Will followup.

[commit-bot: I haz the power, 2016-12-21 14:23:50]

Description was changed from

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278

Review-Url: https://codereview.chromium.org/2596813002
==========

to

==========
Remove ChromeBrowserProvider::CreateInfoBarView() method.

With the code upstream, the implementation can now be inlined and the
indirection is no longer necessary. Removing it and moving definition
of the interfaces to ios/chrome/browser/ui/infobars/.

BUG=676278

Committed: https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b
Cr-Commit-Position: refs/heads/master@{#440090}
==========

[commit-bot: I haz the power, 2016-12-21 14:23:51]

Patchset 1 (id:??) landed as
https://crrev.com/6cfb9447b778c874962bc8f3df5b4f53372cd36b
Cr-Commit-Position: refs/heads/master@{#440090}