Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2593993002: Remove ChromeBrowserProvider::GetLiveTabContextProvider() method. (Closed)

Created:
4 years ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, markusheintz_, pkl (ping after 24h if needed), msramek+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeBrowserProvider::GetLiveTabContextProvider() method. The LiveTabContextProvider class implementation can be inlined in the sole user, removed and the accessor can also removed from the provider too. Add public_deps on :sessions_private from :sessions and restrict the visibility of the target (they cannot yet be merged as one of them uses ARC while not the other). BUG=676278 Committed: https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4 Cr-Commit-Position: refs/heads/master@{#441113}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase and fix "gn check". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -241 lines) Patch
M ios/chrome/browser/BUILD.gn View 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/crash_report/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.mm View 1 chunk +1 line, -10 lines 0 comments Download
M ios/chrome/browser/sessions/BUILD.gn View 5 chunks +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.mm View 2 chunks +31 lines, -8 lines 0 comments Download
D ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ios/chrome/browser/sessions/tab_restore_service_delegate_provider_impl.mm View 1 chunk +0 lines, -64 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/main/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +1 line, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/sessions/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/live_tab_context_provider.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.mm View 3 chunks +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-21 14:36:15 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-21 14:42:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593993002/40001
3 years, 11 months ago (2017-01-03 12:25:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/129271)
3 years, 11 months ago (2017-01-03 12:30:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593993002/60001
3 years, 11 months ago (2017-01-03 12:56:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
3 years, 11 months ago (2017-01-03 13:48:59 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 13:52:34 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9464d6f0321be5f3c8e2ebcd6a2ef9a1e6fe87c4
Cr-Commit-Position: refs/heads/master@{#441113}

Powered by Google App Engine
This is Rietveld 408576698