Media Controls: use loadedmetadata and error events.

Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612
Cr-Commit-Position: refs/heads/master@{#439503}

[mlamouri (slow - plz ping), 2016-12-19 15:58:20]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2016-12-19 15:58:26]

PTAL

[commit-bot: I haz the power, 2016-12-19 15:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 17:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:41:39]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-12-19 17:41:40]

lgtm w/ question

https://codereview.chromium.org/2589873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (left):

https://codereview.chromium.org/2589873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:1501: if
(mediaControls())
Question: I saw the error event is only fired in the true branch above. Is it
safe to remove this?

[mlamouri (slow - plz ping), 2016-12-19 17:57:26]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-19 17:57:26]

Thanks! :)

https://codereview.chromium.org/2589873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (left):

https://codereview.chromium.org/2589873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:1501: if
(mediaControls())
On 2016/12/19 at 17:41:39, Zhiqiang Zhang wrote:
> Question: I saw the error event is only fired in the true branch above. Is it
safe to remove this?

`mediaEngineError()` and `noneSupported()` both fire a an error event. It is
true that if none of the branches are taken, the event will not be fired and we
would have still reset the controls before. I think if that happens to be a
problem, it's a problem for all type of controls.

[commit-bot: I haz the power, 2016-12-19 17:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:02:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482170246171810, "parent_rev":
"9fd451697ca0a29d0f62243d2420f959b96c2344", "commit_rev":
"b7bc72aeae97f244cda31be4ec1121cf7b466721"}

[commit-bot: I haz the power, 2016-12-19 18:03:23]

Description was changed from

==========
Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org
==========

to

==========
Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2589873002
==========

[commit-bot: I haz the power, 2016-12-19 18:03:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-19 18:07:19]

Description was changed from

==========
Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2589873002
==========

to

==========
Media Controls: use loadedmetadata and error events.

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612
Cr-Commit-Position: refs/heads/master@{#439503}
==========

[commit-bot: I haz the power, 2016-12-19 18:07:19]

Patchset 1 (id:??) landed as
https://crrev.com/b7560683aca33e39e1a4629118267d9e2299d612
Cr-Commit-Position: refs/heads/master@{#439503}