Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2587083002: Media Controls: add comments regarding cast/remote related calls from element. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: add comments regarding cast/remote related calls from element. We can't really make the calls use an event in the current situation. Adding TODO's to explain how it should be done and rename methods for future usage BUG=662761 R=zqzhang@chromium.org Committed: https://crrev.com/5a88699d96b19b3895630c526243411d13873ae5 Cr-Commit-Position: refs/heads/master@{#439514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +24 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 3 chunks +17 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
mlamouri (slow - plz ping)
PTAL
4 years ago (2016-12-19 17:34:00 UTC) #2
Zhiqiang Zhang (Slow)
lgtm
4 years ago (2016-12-19 17:49:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587083002/1
4 years ago (2016-12-19 18:42:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 18:55:34 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 18:58:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a88699d96b19b3895630c526243411d13873ae5
Cr-Commit-Position: refs/heads/master@{#439514}

Powered by Google App Engine
This is Rietveld 408576698