Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2589873002: Media Controls: use loadedmetadata and error events. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
index ded935a0092d3d06e13923cd97696ba24552c43c..bd03224eddbf5a30289fc42bcf28e9116ab52fdb 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
@@ -748,6 +748,18 @@ void MediaControls::onTextTracksChanged() {
m_toggleClosedCaptionsButton->updateDisplayType();
}
+void MediaControls::onError() {
+ // TODO(mlamouri): we should only change the aspects of the control that need
+ // to be changed.
+ reset();
+}
+
+void MediaControls::onLoadedMetadata() {
+ // TODO(mlamouri): we should only change the aspects of the control that need
+ // to be changed.
+ reset();
+}
+
void MediaControls::notifyPanelWidthChanged(const LayoutUnit& newWidth) {
// Don't bother to do any work if this matches the most recent panel
// width, since we're called after layout.

Powered by Google App Engine
This is Rietveld 408576698