Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Issue 2589873002: Media Controls: use loadedmetadata and error events. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
index d440d055683b93a81d63f916d456e943c92c88c7..b2a71ec36714383e6fb02d20d98032540c95e9d1 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
@@ -26,6 +26,10 @@ MediaControlsMediaEventListener::MediaControlsMediaEventListener(
false);
m_mediaControls->m_mediaElement->addEventListener(
EventTypeNames::durationchange, this, false);
+ m_mediaControls->m_mediaElement->addEventListener(EventTypeNames::error, this,
+ false);
+ m_mediaControls->m_mediaElement->addEventListener(
+ EventTypeNames::loadedmetadata, this, false);
// TextTracks events.
TextTrackList* textTracks = m_mediaControls->m_mediaElement->textTracks();
@@ -66,6 +70,14 @@ void MediaControlsMediaEventListener::handleEvent(
m_mediaControls->onPause();
return;
}
+ if (event->type() == EventTypeNames::error) {
+ m_mediaControls->onError();
+ return;
+ }
+ if (event->type() == EventTypeNames::loadedmetadata) {
+ m_mediaControls->onLoadedMetadata();
+ return;
+ }
// TextTracks events.
if (event->type() == EventTypeNames::addtrack ||

Powered by Google App Engine
This is Rietveld 408576698