Use timer task runner for V8PerIsolate tasks

Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post per-isolate
tasks to renderer-wide timer task queue.

BUG=676805
Committed: https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e
Cr-Commit-Position: refs/heads/master@{#441114}

[altimin, 2016-12-21 15:57:43]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:58:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:14:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2016-12-21 16:55:50]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:20:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2016-12-21 20:00:08]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 20:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:25:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2016-12-22 17:30:33]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 17:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 17:58:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[altimin, 2016-12-22 18:57:39]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 18:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 20:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:52:25]

Dry run: This issue passed the CQ dry run.

[altimin, 2016-12-23 11:21:55]

altimin@chromium.org changed reviewers:
+ jochen@chromium.org

[altimin, 2016-12-23 11:21:56]

PTAL

[jochen (gone - plz use gerrit), 2016-12-23 11:52:54]

could you please explain the rational for this change (preferably in the CL
description)? Also please link to a tracking bug

[altimin, 2016-12-23 11:57:44]

Description was changed from

==========
Use timer task runner for V8PerIsolate tasks
==========

to

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=624696
==========

[altimin, 2016-12-23 12:01:31]

Description was changed from

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=624696
==========

to

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=676805
==========

[altimin, 2016-12-23 12:01:46]

On 2016/12/23 11:52:54, jochen wrote:
> could you please explain the rational for this change (preferably in the CL
> description)? Also please link to a tracking bug

Sorry, done. PTAL

[jochen (gone - plz use gerrit), 2016-12-23 12:03:38]

lgtm, thx

[altimin, 2016-12-23 12:07:00]

altimin@chromium.org changed reviewers:
+ cbentzel@chromium.org, rockot@chromium.org

[altimin, 2016-12-23 12:07:01]

+ cbentzel@ for net/
+ rockot@ for mojo/

PTAL

[haraken, 2016-12-23 14:16:06]

WebKit LGTM

[Ken Rockot(use gerrit already), 2016-12-27 18:27:20]

rockot@chromium.org changed reviewers:
+ haraken@chromium.org

[Ken Rockot(use gerrit already), 2016-12-27 18:27:21]

lgtm

[cbentzel, 2017-01-02 21:38:38]

net LGTM (sorry for delay)

[altimin, 2017-01-03 10:40:21]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2017-01-03 10:40:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 14:07:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483440021731070,
"parent_rev": "53650fd17606827987c857ba200170367fdc73ce", "commit_rev":
"f893732b92955ac4f275f7c1f7010d07aeb2f0a0"}

[commit-bot: I haz the power, 2017-01-03 14:07:27]

Description was changed from

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=676805
==========

to

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=676805

Review-Url: https://codereview.chromium.org/2589363003
==========

[commit-bot: I haz the power, 2017-01-03 14:07:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2017-01-03 14:10:01]

Description was changed from

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=676805

Review-Url: https://codereview.chromium.org/2589363003
==========

to

==========
Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post
per-isolate
tasks to renderer-wide timer task queue.

BUG=676805

Committed: https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e
Cr-Commit-Position: refs/heads/master@{#441114}
==========

[commit-bot: I haz the power, 2017-01-03 14:10:03]

Patchset 5 (id:??) landed as
https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e
Cr-Commit-Position: refs/heads/master@{#441114}

[Ken Rockot(use gerrit already), 2017-01-10 22:20:23]

https://codereview.chromium.org/2589363003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2589363003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:408:
V8PerIsolateData::initialize(scheduler->timerTaskRunner());
I would be surprised if we aren't seeing crashes in the wild because of this CL.
There is an implementation of WebThread in use for content utility processes
which always has a null scheduler(). If we're seeing crashes, we should probably
revert and reland once this code can be changed or we add a scheduler impl to
WebThreadImplForUtilityThread.