Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2589363003: Use timer task runner for V8PerIsolate tasks (Closed)
Patch Set: One more fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index c87a50e8c0bd779fb30cdfbc6dcd8899a6952c93..e6e7ce8ed3835089017642f63ae9bedf72b2b30e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -53,8 +53,9 @@ static void microtasksCompletedCallback(v8::Isolate* isolate) {
V8PerIsolateData::from(isolate)->runEndOfScopeTasks();
}
-V8PerIsolateData::V8PerIsolateData()
- : m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>()),
+V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)
+ : m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>(
+ taskRunner->toSingleThreadTaskRunner())),
m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),
m_hiddenValue(V8HiddenValue::create()),
m_privateProperty(V8PrivateProperty::create()),
@@ -78,8 +79,8 @@ v8::Isolate* V8PerIsolateData::mainThreadIsolate() {
return mainThreadPerIsolateData->isolate();
}
-v8::Isolate* V8PerIsolateData::initialize() {
- V8PerIsolateData* data = new V8PerIsolateData();
+v8::Isolate* V8PerIsolateData::initialize(WebTaskRunner* taskRunner) {
+ V8PerIsolateData* data = new V8PerIsolateData(taskRunner);
v8::Isolate* isolate = data->isolate();
isolate->SetData(gin::kEmbedderBlink, data);
return isolate;

Powered by Google App Engine
This is Rietveld 408576698