Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: gin/public/isolate_holder.h

Issue 2589363003: Use timer task runner for V8PerIsolate tasks (Closed)
Patch Set: One more fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index 7cf3d94ac898bed0ce2023d670fdb59082471e78..62b871085805716db97938f3dda6a44888cbfca6 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -8,10 +8,15 @@
#include <memory>
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "gin/gin_export.h"
#include "gin/public/v8_idle_task_runner.h"
#include "v8/include/v8.h"
+namespace base {
+class SingleThreadTaskRunner;
+}
+
namespace gin {
class PerIsolateData;
@@ -42,8 +47,10 @@ class GIN_EXPORT IsolateHolder {
kStableAndExperimentalV8Extras,
};
- IsolateHolder();
- explicit IsolateHolder(AccessMode access_mode);
+ explicit IsolateHolder(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+ IsolateHolder(scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ AccessMode access_mode);
~IsolateHolder();
// Should be invoked once before creating IsolateHolder instances to

Powered by Google App Engine
This is Rietveld 408576698