Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Side by Side Diff: gin/shell_runner_unittest.cc

Issue 2589363003: Use timer task runner for V8PerIsolate tasks (Closed)
Patch Set: One more fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/shell_runner.h" 5 #include "gin/shell_runner.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/threading/thread_task_runner_handle.h"
9 #include "gin/array_buffer.h" 10 #include "gin/array_buffer.h"
10 #include "gin/converter.h" 11 #include "gin/converter.h"
11 #include "gin/public/isolate_holder.h" 12 #include "gin/public/isolate_holder.h"
12 #include "gin/v8_initializer.h" 13 #include "gin/v8_initializer.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 15
15 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 16 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
16 #include "gin/public/isolate_holder.h" 17 #include "gin/public/isolate_holder.h"
17 #endif 18 #endif
18 19
19 using v8::Isolate; 20 using v8::Isolate;
20 using v8::Object; 21 using v8::Object;
21 using v8::Script; 22 using v8::Script;
22 using v8::String; 23 using v8::String;
23 24
24 namespace gin { 25 namespace gin {
25 26
26 TEST(RunnerTest, Run) { 27 TEST(RunnerTest, Run) {
27 base::MessageLoop message_loop; 28 base::MessageLoop message_loop;
28 std::string source = "this.result = 'PASS';\n"; 29 std::string source = "this.result = 'PASS';\n";
29 30
30 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 31 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
31 gin::V8Initializer::LoadV8Snapshot(); 32 gin::V8Initializer::LoadV8Snapshot();
32 gin::V8Initializer::LoadV8Natives(); 33 gin::V8Initializer::LoadV8Natives();
33 #endif 34 #endif
34 35
35 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode, 36 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
36 gin::IsolateHolder::kStableV8Extras, 37 gin::IsolateHolder::kStableV8Extras,
37 gin::ArrayBufferAllocator::SharedInstance()); 38 gin::ArrayBufferAllocator::SharedInstance());
38 gin::IsolateHolder instance; 39 gin::IsolateHolder instance(base::ThreadTaskRunnerHandle::Get());
39 40
40 ShellRunnerDelegate delegate; 41 ShellRunnerDelegate delegate;
41 Isolate* isolate = instance.isolate(); 42 Isolate* isolate = instance.isolate();
42 ShellRunner runner(&delegate, isolate); 43 ShellRunner runner(&delegate, isolate);
43 Runner::Scope scope(&runner); 44 Runner::Scope scope(&runner);
44 runner.Run(source, "test_data.js"); 45 runner.Run(source, "test_data.js");
45 46
46 std::string result; 47 std::string result;
47 EXPECT_TRUE(Converter<std::string>::FromV8(isolate, 48 EXPECT_TRUE(Converter<std::string>::FromV8(isolate,
48 runner.global()->Get(StringToV8(isolate, "result")), 49 runner.global()->Get(StringToV8(isolate, "result")),
49 &result)); 50 &result));
50 EXPECT_EQ("PASS", result); 51 EXPECT_EQ("PASS", result);
51 } 52 }
52 53
53 } // namespace gin 54 } // namespace gin
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698