Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2588603002: Specify TaskType of posted Task explicitly in media elements (12) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in media elements The base Media elements spec has TaskType::MediaElementEvent as its own task source. It should be used as the default, unless explicitly overridden by derived specs. https://html.spec.whatwg.org/multipage/embedded-content.html#media-elements Both Remote Playback API and Web Audio API also don't override it, so we should use TaskType::MediaElementEvent here. https://w3c.github.io/remote-playback/ https://webaudio.github.io/web-audio-api/ BUG=624696 Committed: https://crrev.com/735320322f9380110505879c807a606f82ee2ee4 Cr-Commit-Position: refs/heads/master@{#439426}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Messages

Total messages: 16 (11 generated)
tzik
PTAL
4 years ago (2016-12-18 22:45:44 UTC) #7
haraken
LGTM
4 years ago (2016-12-19 00:14:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588603002/40001
4 years ago (2016-12-19 05:54:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-19 07:49:01 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 07:50:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/735320322f9380110505879c807a606f82ee2ee4
Cr-Commit-Position: refs/heads/master@{#439426}

Powered by Google App Engine
This is Rietveld 408576698