third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp - Issue 2588603002: Specify TaskType of posted Task explicitly in media elements (12)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

Issue 2588603002: Specify TaskType of posted Task explicitly in media elements (12) (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

index bbad0a3e3b12db8c688fda22eb9454ecef5be325..0ce6f6405d357fa61f67eb5f675bf9e310c22e5d 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

@@ -27,6 +27,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/ExecutionContextTask.h"

+#include "core/dom/TaskRunnerHelper.h"

#include "modules/EventModules.h"

#include "modules/webaudio/BaseAudioContext.h"

#include "platform/audio/AudioUtilities.h"

@@ -221,7 +222,7 @@ void AudioScheduledSourceHandler::finish() {

if (context()->getExecutionContext()) {

context()->getExecutionContext()->postTask(

- BLINK_FROM_HERE,

+ TaskType::MediaElementEvent, BLINK_FROM_HERE,

createCrossThreadTask(&AudioScheduledSourceHandler::notifyEnded,

PassRefPtr<AudioScheduledSourceHandler>(this)));

}