third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 2588603002: Specify TaskType of posted Task explicitly in media elements (12)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 2588603002: Specify TaskType of posted Task explicitly in media elements (12) (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index 930521a4388db543ea8b21d017caeafddb40c072..2b343435014e5c1de43aa2b03ef702b6bdf91b37 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -26,6 +26,7 @@

#include "modules/webaudio/OfflineAudioDestinationNode.h"

#include "core/dom/ExecutionContextTask.h"

+#include "core/dom/TaskRunnerHelper.h"

#include "modules/webaudio/AudioNodeInput.h"

#include "modules/webaudio/AudioNodeOutput.h"

#include "modules/webaudio/BaseAudioContext.h"

@@ -216,7 +217,7 @@ void OfflineAudioDestinationHandler::suspendOfflineRendering() {

// The actual rendering has been suspended. Notify the context.

if (context()->getExecutionContext()) {

context()->getExecutionContext()->postTask(

- BLINK_FROM_HERE,

+ TaskType::MediaElementEvent, BLINK_FROM_HERE,

createCrossThreadTask(&OfflineAudioDestinationHandler::notifySuspend,

PassRefPtr<OfflineAudioDestinationHandler>(this),

context()->currentSampleFrame()));

@@ -229,9 +230,9 @@ void OfflineAudioDestinationHandler::finishOfflineRendering() {

// The actual rendering has been completed. Notify the context.

if (context()->getExecutionContext()) {

context()->getExecutionContext()->postTask(

- BLINK_FROM_HERE, createCrossThreadTask(

- &OfflineAudioDestinationHandler::notifyComplete,

- PassRefPtr<OfflineAudioDestinationHandler>(this)));

+ TaskType::MediaElementEvent, BLINK_FROM_HERE,

+ createCrossThreadTask(&OfflineAudioDestinationHandler::notifyComplete,

+ wrapPassRefPtr(this)));

}