Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 25846002: Use vertexless shaders when NVpr is available (Closed)

Created:
7 years, 2 months ago by Chris Dalton
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use vertexless shaders when NVpr is available Adds support for vertexless shaders and enables them when NV_path_rendering is available. This takes a GrGLFragmentOnlyShaderBuilder class, a GrGLTexGenEffectArray class, support for setting TexGen and the projection matrix in GrGpuGL, and code for setting the GL fixed function state where necessary. Committed: http://code.google.com/p/skia/source/detail?r=11620

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Oops, make all the tests pass #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : Fix mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+767 lines, -269 lines) Patch
M src/gpu/gl/GrGLProgram.h View 3 chunks +8 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 10 chunks +64 lines, -42 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 1 2 3 4 7 chunks +134 lines, -40 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 2 3 7 chunks +313 lines, -139 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 2 chunks +32 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 3 chunks +20 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 chunks +125 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 3 chunks +39 lines, -42 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Chris Dalton
7 years, 2 months ago (2013-10-03 07:57:23 UTC) #1
bsalomon
On 2013/10/03 07:57:23, Chris Dalton wrote: lgtm
7 years, 2 months ago (2013-10-03 15:40:19 UTC) #2
Kimmo Kinnunen
https://chromiumcodereview.appspot.com/25846002/diff/15001/src/gpu/gl/GrGLProgramEffects.h File src/gpu/gl/GrGLProgramEffects.h (right): https://chromiumcodereview.appspot.com/25846002/diff/15001/src/gpu/gl/GrGLProgramEffects.h#newcode175 src/gpu/gl/GrGLProgramEffects.h:175: , fFirstTexCoordIdx(0) This variable is never set in release ...
7 years, 2 months ago (2013-10-04 11:02:32 UTC) #3
Chris Dalton
Yikes, good catch Kimmo. This fixes it. I simplified the TexGen stuff. While I was ...
7 years, 2 months ago (2013-10-04 19:09:03 UTC) #4
bsalomon
On 2013/10/04 19:09:03, Chris Dalton wrote: > Yikes, good catch Kimmo. > > This fixes ...
7 years, 2 months ago (2013-10-04 19:33:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/25846002/20001
7 years, 2 months ago (2013-10-04 19:33:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildSkiaLib http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=750
7 years, 2 months ago (2013-10-04 19:38:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/25846002/33001
7 years, 2 months ago (2013-10-04 19:52:20 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 20:02:57 UTC) #9
Message was sent while issue was closed.
Change committed as 11620

Powered by Google App Engine
This is Rietveld 408576698